-
Notifications
You must be signed in to change notification settings - Fork 80
Add options page to enable/disable auto-submit for filled forms #95
Conversation
dc235e6
to
48b846a
Compare
Hey @jayme-github, thanks for the PR! Although github doesn't show code conflicts, with all the recent PRs merged I think your code is not working anymore. I tried to fix some obvious things, but all I got is autoLogin being always disabled, even if I enable it in options. If you are still interested in getting this merged, could you please have another look? Maybe I'm missing something obvious. |
chrome/manifest.json
Outdated
@@ -9,6 +9,12 @@ | |||
"background": { | |||
"persistent": false, | |||
"scripts": ["background.js"] | |||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
comma is missing :)
@@ -0,0 +1,18 @@ | |||
function save_options() { | |||
var autoSubmit = document.getElementById('auto-submit').checked; | |||
localStorage.setItem('autoSubmit', autoSubmit); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we should close settings on Save? I think a simple window.close();
would do it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct, added window.close();
9660a70
to
dfb0df0
Compare
dfb0df0
to
dd0ff2a
Compare
Sorry for pushing broken stuff, I needed to leave quickly yesterday. Rebased to current master and fixed functionality. |
Works like a charm, thanks :) |
I've added a very(!) simple options page to support disabling of auto-submit for forms.
Maybe someone can do some testing with firefox as I'm not sure if this is working cross browser (albeit I've used
localStorage
in favor of the, I guess, browser specificstorage
orchrome.storage
APIs).fixes #94