This repository has been archived by the owner on May 27, 2019. It is now read-only.
Add options page to enable/disable auto-submit for filled forms #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jayme-github
force-pushed
the
toggle-autosubmit
branch
from
dc235e6
to
48b846a
Compare
|
Hey @jayme-github, thanks for the PR! Although github doesn't show code conflicts, with all the recent PRs merged I think your code is not working anymore. I tried to fix some obvious things, but all I got is autoLogin being always disabled, even if I enable it in options. If you are still interested in getting this merged, could you please have another look? Maybe I'm missing something obvious. |
maximbaz
suggested changes
Sep 14, 2017
chrome/manifest.json
Outdated
| @@ -9,6 +9,12 @@ | |||
| "background": { | |||
| "persistent": false, | |||
| "scripts": ["background.js"] | |||
| } | |||
| @@ -0,0 +1,18 @@ | |||
| function save_options() { | |||
| var autoSubmit = document.getElementById('auto-submit').checked; | |||
| localStorage.setItem('autoSubmit', autoSubmit); | |||
There was a problem hiding this comment.
Maybe we should close settings on Save? I think a simple window.close(); would do it.
There was a problem hiding this comment.
Correct, added window.close();
jayme-github
force-pushed
the
toggle-autosubmit
branch
2 times, most recently
from
9660a70
to
dfb0df0
Compare
jayme-github
force-pushed
the
toggle-autosubmit
branch
from
dfb0df0
to
dd0ff2a
Compare
|
Sorry for pushing broken stuff, I needed to leave quickly yesterday. Rebased to current master and fixed functionality. |
maximbaz
approved these changes
Sep 15, 2017
|
Works like a charm, thanks :) |
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added a very(!) simple options page to support disabling of auto-submit for forms.
Maybe someone can do some testing with firefox as I'm not sure if this is working cross browser (albeit I've used
localStoragein favor of the, I guess, browser specificstorageorchrome.storageAPIs).fixes #94