fix: fix splitCommonDiff function to work correctly on common digits …

…after first difference (#1543) Co-authored-by: henri.schmidt <henri.schmidt@zdf.jp>
browserslist · Apr 5, 2024 · ae3981c · ae3981c
1 parent f014612
commit ae3981c
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/src/numbers/segment.spec.ts b/src/numbers/segment.spec.ts
@@ -125,6 +125,16 @@ describe('Numbers', () => {
           12
         ])
       })
+
+      it('should work correctly, if there are common digits after first difference', () => {
+        expect(
+          splitCommonDiff([1, 0, 3], [1, 2, 3])
+        ).toEqual(['1', 3, 23])
+
+        expect(
+          splitCommonDiff([1, 2, 5, 2], [1, 4, 5, 3])
+        ).toEqual(['1', 252, 453])
+      })
     })
 
     describe('segmentToNumberPatterns', () => {

diff --git a/src/numbers/segment.ts b/src/numbers/segment.ts
@@ -100,7 +100,7 @@ export function splitCommonDiff(a: number[], b: number[]): [string, number, numb
     currA = a[i]
     currB = b[i]
 
-    if (currA === currB) {
+    if (currA === currB && diffA === '' && diffB === '') {
       common += currA
     } else {
       diffA += currA