adding username and access key to the info and stop commands as arg o…

…ption
browserstack · Jun 29, 2020 · 5d46100 · 5d46100
1 parent 87ab6e4
commit 5d46100
Show file tree

Hide file tree

Showing 4 changed files with 56 additions and 0 deletions.
diff --git a/bin/commands/info.js b/bin/commands/info.js
@@ -10,6 +10,12 @@ module.exports = function info(args) {
   let bsConfigPath = process.cwd() + args.cf;
 
   return utils.validateBstackJson(bsConfigPath).then(function (bsConfig) {
+    // accept the username from command line if provided
+    utils.setUsername(bsConfig, args);
+
+    // accept the access key from command line if provided
+    utils.setAccessKey(bsConfig, args);
+
     utils.setUsageReportingFlag(bsConfig, args.disableUsageReporting);
 
     let buildId = args._[1];

diff --git a/bin/commands/stop.js b/bin/commands/stop.js
@@ -10,6 +10,12 @@ module.exports = function stop(args) {
   let bsConfigPath = process.cwd() + args.cf;
 
   return utils.validateBstackJson(bsConfigPath).then(function (bsConfig) {
+    // accept the username from command line if provided
+    utils.setUsername(bsConfig, args);
+
+    // accept the access key from command line if provided
+    utils.setAccessKey(bsConfig, args);
+
     utils.setUsageReportingFlag(bsConfig, args.disableUsageReporting);
 
     let buildId = args._[1];

diff --git a/test/unit/bin/commands/info.js b/test/unit/bin/commands/info.js
@@ -22,6 +22,8 @@ describe("buildInfo", () => {
 
     beforeEach(() => {
       sandbox = sinon.createSandbox();
+      setUsernameStub = sandbox.stub();
+      setAccessKeyStub = sandbox.stub();
       validateBstackJsonStub = sandbox.stub();
       setUsageReportingFlagStub = sandbox.stub().returns(undefined);
       getUserAgentStub = sandbox.stub().returns("random user-agent");
@@ -45,6 +47,8 @@ describe("buildInfo", () => {
 
       const info = proxyquire("../../../../bin/commands/info", {
         "../helpers/utils": {
+          setUsername: setUsernameStub,
+          setAccessKey: setAccessKeyStub,
           validateBstackJson: validateBstackJsonStub,
           getErrorCodeFromErr: getErrorCodeFromErrStub,
           sendUsageReport: sendUsageReportStub,
@@ -77,6 +81,8 @@ describe("buildInfo", () => {
 
       const info = proxyquire("../../../../bin/commands/info", {
         "../helpers/utils": {
+          setUsername: setUsernameStub,
+          setAccessKey: setAccessKeyStub,
           validateBstackJson: validateBstackJsonStub,
           getErrorCodeFromErr: getErrorCodeFromErrStub,
           sendUsageReport: sendUsageReportStub,
@@ -103,6 +109,8 @@ describe("buildInfo", () => {
   describe("Handle statusCode != 200", () => {
     beforeEach(() => {
       sandbox = sinon.createSandbox();
+      setUsernameStub = sandbox.stub();
+      setAccessKeyStub = sandbox.stub();
       validateBstackJsonStub = sandbox.stub();
       setUsageReportingFlagStub = sandbox.stub().returns(undefined);
       getUserAgentStub = sandbox.stub().returns("random user-agent");
@@ -128,6 +136,8 @@ describe("buildInfo", () => {
 
       const info = proxyquire("../../../../bin/commands/info", {
         "../helpers/utils": {
+          setUsername: setUsernameStub,
+          setAccessKey: setAccessKeyStub,
           validateBstackJson: validateBstackJsonStub,
           getErrorCodeFromErr: getErrorCodeFromErrStub,
           sendUsageReport: sendUsageReportStub,
@@ -166,6 +176,8 @@ describe("buildInfo", () => {
 
       const info = proxyquire("../../../../bin/commands/info", {
         "../helpers/utils": {
+          setUsername: setUsernameStub,
+          setAccessKey: setAccessKeyStub,
           validateBstackJson: validateBstackJsonStub,
           getErrorCodeFromErr: getErrorCodeFromErrStub,
           sendUsageReport: sendUsageReportStub,
@@ -199,6 +211,8 @@ describe("buildInfo", () => {
 
       const info = proxyquire("../../../../bin/commands/info", {
         "../helpers/utils": {
+          setUsername: setUsernameStub,
+          setAccessKey: setAccessKeyStub,
           validateBstackJson: validateBstackJsonStub,
           getErrorCodeFromErr: getErrorCodeFromErrStub,
           sendUsageReport: sendUsageReportStub,
@@ -227,6 +241,8 @@ describe("buildInfo", () => {
 
     beforeEach(() => {
       sandbox = sinon.createSandbox();
+      setUsernameStub = sandbox.stub();
+      setAccessKeyStub = sandbox.stub();
       validateBstackJsonStub = sandbox.stub();
       setUsageReportingFlagStub = sandbox.stub().returns(undefined);
       getUserAgentStub = sandbox.stub().returns("random user-agent");
@@ -250,6 +266,8 @@ describe("buildInfo", () => {
 
       const info = proxyquire("../../../../bin/commands/info", {
         "../helpers/utils": {
+          setUsername: setUsernameStub,
+          setAccessKey: setAccessKeyStub,
           validateBstackJson: validateBstackJsonStub,
           getErrorCodeFromErr: getErrorCodeFromErrStub,
           sendUsageReport: sendUsageReportStub,
@@ -277,6 +295,8 @@ describe("buildInfo", () => {
 
     beforeEach(() => {
       sandbox = sinon.createSandbox();
+      setUsernameStub = sandbox.stub();
+      setAccessKeyStub = sandbox.stub();
       validateBstackJsonStub = sandbox.stub();
       setUsageReportingFlagStub = sandbox.stub().returns(undefined);
       sendUsageReportStub = sandbox.stub().callsFake(function () {
@@ -293,6 +313,8 @@ describe("buildInfo", () => {
     it("send usage report if validateBstackJson fails", () => {
       const info = proxyquire("../../../../bin/commands/info", {
         "../helpers/utils": {
+          setUsername: setUsernameStub,
+          setAccessKey: setAccessKeyStub,
           validateBstackJson: validateBstackJsonStub,
           getErrorCodeFromErr: getErrorCodeFromErrStub,
           sendUsageReport: sendUsageReportStub,

diff --git a/test/unit/bin/commands/stop.js b/test/unit/bin/commands/stop.js
@@ -23,6 +23,8 @@ describe("buildStop", () => {
     beforeEach(() => {
       sandbox = sinon.createSandbox();
       validateBstackJsonStub = sandbox.stub();
+      setUsernameStub = sandbox.stub();
+      setAccessKeyStub = sandbox.stub();
       setUsageReportingFlagStub = sandbox.stub().returns(undefined);
       getUserAgentStub = sandbox.stub().returns("random user-agent");
       sendUsageReportStub = sandbox.stub().callsFake(function () {
@@ -48,6 +50,8 @@ describe("buildStop", () => {
       const stop = proxyquire("../../../../bin/commands/stop", {
         "../helpers/utils": {
           validateBstackJson: validateBstackJsonStub,
+          setUsername: setUsernameStub,
+          setAccessKey: setAccessKeyStub,
           getErrorCodeFromErr: getErrorCodeFromErrStub,
           sendUsageReport: sendUsageReportStub,
           setUsageReportingFlag: setUsageReportingFlagStub,
@@ -82,6 +86,8 @@ describe("buildStop", () => {
         "../helpers/utils": {
           validateBstackJson: validateBstackJsonStub,
           getErrorCodeFromErr: getErrorCodeFromErrStub,
+          setUsername: setUsernameStub,
+          setAccessKey: setAccessKeyStub,
           sendUsageReport: sendUsageReportStub,
           setUsageReportingFlag: setUsageReportingFlagStub,
           getUserAgent: getUserAgentStub,
@@ -106,6 +112,8 @@ describe("buildStop", () => {
   describe("Handle statusCode != 200", () => {
     beforeEach(() => {
       sandbox = sinon.createSandbox();
+      setUsernameStub = sandbox.stub();
+      setAccessKeyStub = sandbox.stub();
       validateBstackJsonStub = sandbox.stub();
       setUsageReportingFlagStub = sandbox.stub().returns(undefined);
       getUserAgentStub = sandbox.stub().returns("random user-agent");
@@ -134,6 +142,8 @@ describe("buildStop", () => {
           validateBstackJson: validateBstackJsonStub,
           getErrorCodeFromErr: getErrorCodeFromErrStub,
           sendUsageReport: sendUsageReportStub,
+          setUsername: setUsernameStub,
+          setAccessKey: setAccessKeyStub,
           setUsageReportingFlag: setUsageReportingFlagStub,
           getUserAgent: getUserAgentStub,
         },
@@ -174,6 +184,8 @@ describe("buildStop", () => {
           validateBstackJson: validateBstackJsonStub,
           getErrorCodeFromErr: getErrorCodeFromErrStub,
           sendUsageReport: sendUsageReportStub,
+          setUsername: setUsernameStub,
+          setAccessKey: setAccessKeyStub,
           setUsageReportingFlag: setUsageReportingFlagStub,
           getUserAgent: getUserAgentStub,
         },
@@ -209,6 +221,8 @@ describe("buildStop", () => {
           validateBstackJson: validateBstackJsonStub,
           getErrorCodeFromErr: getErrorCodeFromErrStub,
           sendUsageReport: sendUsageReportStub,
+          setUsername: setUsernameStub,
+          setAccessKey: setAccessKeyStub,
           setUsageReportingFlag: setUsageReportingFlagStub,
           getUserAgent: getUserAgentStub,
         },
@@ -234,6 +248,8 @@ describe("buildStop", () => {
 
     beforeEach(() => {
       sandbox = sinon.createSandbox();
+      setUsernameStub = sandbox.stub();
+      setAccessKeyStub = sandbox.stub();
       validateBstackJsonStub = sandbox.stub();
       setUsageReportingFlagStub = sandbox.stub().returns(undefined);
       getUserAgentStub = sandbox.stub().returns("random user-agent");
@@ -262,6 +278,8 @@ describe("buildStop", () => {
           validateBstackJson: validateBstackJsonStub,
           getErrorCodeFromErr: getErrorCodeFromErrStub,
           sendUsageReport: sendUsageReportStub,
+          setUsername: setUsernameStub,
+          setAccessKey: setAccessKeyStub,
           setUsageReportingFlag: setUsageReportingFlagStub,
           getUserAgent: getUserAgentStub,
         },
@@ -287,6 +305,8 @@ describe("buildStop", () => {
 
     beforeEach(() => {
       sandbox = sinon.createSandbox();
+      setUsernameStub = sandbox.stub();
+      setAccessKeyStub = sandbox.stub();
       validateBstackJsonStub = sandbox.stub();
       setUsageReportingFlagStub = sandbox.stub().returns(undefined);
       sendUsageReportStub = sandbox.stub().callsFake(function () {
@@ -306,6 +326,8 @@ describe("buildStop", () => {
           validateBstackJson: validateBstackJsonStub,
           getErrorCodeFromErr: getErrorCodeFromErrStub,
           sendUsageReport: sendUsageReportStub,
+          setUsername: setUsernameStub,
+          setAccessKey: setAccessKeyStub,
           setUsageReportingFlag: setUsageReportingFlagStub,
         },
       });