Handle spec level timeouts #248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nagpalkaran95
requested changes
Feb 21, 2022
bin/helpers/constants.js
Outdated
| @@ -62,7 +62,9 @@ const userMessages = { | |||
| DOWNLOAD_BUILD_ARTIFACTS_SUCCESS: "Your build artifact(s) have been successfully downloaded in '<user-path>/build_artifacts/<build-id>' directory", | |||
| LATEST_SYNTAX_TO_ACTUAL_VERSION_MESSAGE: "Your build will run using Cypress <actualVersion> as you had specified <latestSyntaxVersion>.<frameworkUpgradeMessage> Read more about supported versions here: http://browserstack.com/docs/automate/cypress/supported-versions", | |||
| PROCESS_KILL_MESSAGE: "Stopping the CLI and the execution of the build on BrowserStack", | |||
| BUILD_FAILED_ERROR: "The above stacktrace has been thrown by Cypress when we tried to run your build. If your test suite requires npm dependencies then please specify them on browserstack.json. Read more at " + chalk.blueBright("https://www.browserstack.com/docs/automate/cypress/npm-packages") + ". Also, we recommend you to try running the build locally using ‘cypress run’ and if it works fine then please reach out to support at " + chalk.blueBright("https://www.browserstack.com/contact#technical-support") | |||
| BUILD_FAILED_ERROR: "The above stacktrace has been thrown by Cypress when we tried to run your build. If your test suite requires npm dependencies then please specify them on browserstack.json. Read more at " + chalk.blueBright("https://www.browserstack.com/docs/automate/cypress/npm-packages") + ". Also, we recommend you to try running the build locally using ‘cypress run’ and if it works fine then please reach out to support at " + chalk.blueBright("https://www.browserstack.com/contact#technical-support"), | |||
| SPEC_LIMIT_WARNING: "Value for the 'spec_timeout' key not in the 1-120 range. Going ahead with 30 mins as the default spec timeout. Read more about how to specify the option in https://browserstack.com/docs/automate/cypress/spec-timeout ", | |||
There was a problem hiding this comment.
Suggested change
| SPEC_LIMIT_WARNING: "Value for the 'spec_timeout' key not in the 1-120 range. Going ahead with 30 mins as the default spec timeout. Read more about how to specify the option in https://browserstack.com/docs/automate/cypress/spec-timeout ", | |
| SPEC_LIMIT_WARNING: "Value for the 'spec_timeout' key not in the 1-120 range. Going ahead with 30 mins as the default spec timeout. Read more about how to specify the option in https://browserstack.com/docs/automate/cypress/spec-timeout", |
| exports.isTrueString = value => (!this.isUndefined(value) && value.toString().toLowerCase() === 'true'); | ||
|
|
||
| exports.isFloat = (value) => Number(value) && Number(value) % 1 !== 0; | ||
|
|
||
| exports.isInteger = (value) => Number.isInteger(value); |
There was a problem hiding this comment.
add tests for these too
| @@ -389,10 +406,26 @@ exports.fixCommaSeparatedString = (string) => { | |||
|
|
|||
| exports.isUndefined = value => (value === undefined || value === null); | |||
|
|
|||
| exports.isPositiveInteger = (str) => { | |||
There was a problem hiding this comment.
add tests for these too
| @@ -168,6 +168,12 @@ var argv = yargs | |||
| type: "string", | |||
| default: undefined | |||
| }, | |||
| 't': { | |||
There was a problem hiding this comment.
Need to add help section for this arg. Also specify mins when giving range in messgae
There was a problem hiding this comment.
by help section do you mean the description have added it under SPEC_TIMEOUT
nagpalkaran95
previously approved these changes
Feb 21, 2022
… into Handle_spec_level_timeouts
… into Handle_spec_level_timeouts
nagpalkaran95
approved these changes
Mar 14, 2022
… into Handle_spec_level_timeouts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes for adding spec level timeouts.