Add null check while updating progress bar #455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pranavj1001
reviewed
Jan 13, 2023
bin/helpers/zipUpload.js
Outdated
Comment on lines
99
to
107
| if (r && r.req && r.req.connection) { | ||
| let dispatched = r.req.connection._bytesDispatched; | ||
| let percent = dispatched * 100.0 / size; | ||
| obj.bar1.update(percent, { | ||
| speed: ((dispatched / (Date.now() - obj.startTime)) / 125).toFixed(2) //kbits per sec | ||
| }); | ||
| } else { | ||
| logger.warn('Connection is undefined/null for zip upload request. Unable to determine progress.'); | ||
| } |
There was a problem hiding this comment.
Let's include this within a try catch block to catch errors that might come from other lines of code.
pranavj1001
reviewed
Jan 13, 2023
bin/helpers/zipUpload.js
Outdated
| } | ||
| } catch (error) { | ||
| logger.warn('Unable to determine progress.'); | ||
| logger.error(error); |
There was a problem hiding this comment.
What if we push the error at line 111 and 107?
pranavj1001
approved these changes
Jan 17, 2023
agrawalsaurabhs
deleted the
AFD-1532-null-check-while-updating-progress-bar
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://browserstack.atlassian.net/browse/AFD-1532