Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

initial changes #707

Merged
merged 21 commits into from
Oct 17, 2023
Merged

initial changes #707

merged 21 commits into from
Oct 17, 2023

Conversation

rev-doshi
Copy link
Collaborator

No description provided.

@rev-doshi rev-doshi marked this pull request as ready for review October 11, 2023 06:53
@rev-doshi rev-doshi requested a review from a team as a code owner October 11, 2023 06:53
sauravdas1997
sauravdas1997 previously approved these changes Oct 11, 2023
View reviewed changes
amaanbs
amaanbs requested changes Oct 11, 2023
View reviewed changes
bin/accessibility-automation/cypress/index.js Outdated Show resolved Hide resolved
bin/accessibility-automation/cypress/index.js Outdated Show resolved Hide resolved
bin/accessibility-automation/cypress/index.js Outdated Show resolved Hide resolved
bin/accessibility-automation/cypress/index.js Outdated Show resolved Hide resolved
bin/accessibility-automation/cypress/index.js Outdated Show resolved Hide resolved
bin/accessibility-automation/helper.js Outdated Show resolved Hide resolved
bin/accessibility-automation/helper.js Outdated Show resolved Hide resolved
bin/accessibility-automation/helper.js Show resolved Hide resolved
bin/accessibility-automation/helper.js Outdated Show resolved Hide resolved
bin/accessibility-automation/helper.js Outdated Show resolved Hide resolved
asambstack
asambstack requested changes Oct 12, 2023
View reviewed changes
Copy link
Collaborator

@asambstack asambstack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also please add specs for the changes. The spec files for bin/run.js, bin/helpers/capabilityHelper.js, bin/helpers/utils.js already exist.

bin/accessibility-automation/cypress/index.js Show resolved Hide resolved
bin/accessibility-automation/cypress/index.js Show resolved Hide resolved
bin/accessibility-automation/cypress/index.js Outdated Show resolved Hide resolved
bin/accessibility-automation/cypress/index.js Outdated Show resolved Hide resolved
bin/accessibility-automation/helper.js Outdated Show resolved Hide resolved
bin/helpers/capabilityHelper.js Outdated Show resolved Hide resolved
bin/helpers/helper.js Outdated Show resolved Hide resolved
bin/helpers/utils.js Outdated Show resolved Hide resolved
bin/testObservability/helper/helper.js Show resolved Hide resolved
bin/helpers/helper.js Show resolved Hide resolved
asambstack
asambstack previously approved these changes Oct 12, 2023
View reviewed changes
Copy link
Collaborator

@asambstack asambstack left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. Specs can be added in a separate task.
Please get the approval from AFD QA for the changes.

amaanbs
amaanbs previously approved these changes Oct 12, 2023
View reviewed changes
Copy link
Collaborator

@amaanbs amaanbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's push changes for pending review comments with the UT PR.

@rev-doshi rev-doshi dismissed stale reviews from amaanbs and asambstack via e3e89aa October 13, 2023 13:29
asambstack
asambstack previously approved these changes Oct 16, 2023
View reviewed changes
@agrawalsaurabhs agrawalsaurabhs merged commit b884205 into browserstack:master Oct 17, 2023
3 checks passed
@agrawalsaurabhs agrawalsaurabhs mentioned this pull request Oct 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karanshah-browserstack karanshah-browserstack karanshah-browserstack left review comments

@asambstack asambstack asambstack approved these changes

@sauravdas1997 sauravdas1997 sauravdas1997 approved these changes

@amaanbs amaanbs amaanbs left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@rev-doshi @karanshah-browserstack @asambstack @amaanbs @sauravdas1997 @agrawalsaurabhs