-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[🔨 WIP 🔨] Support running on ATS grid #736
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
||
if (turboScaleSession) { | ||
// remove unwanted path prefix for turboscale | ||
files = files.map((x) => { return path.join(testFolderPath, x.split(testFolderPath)[1]) }) |
Check warning
Code scanning / Semgrep OSS
Semgrep Finding: javascript.lang.security.audit.path-traversal.path-join-resolve-traversal.path-join-resolve-traversal Warning
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we are just trimming few path strings…removing prefix as we expect trimmed down path…
using path.join to be os agnostic.
no impact
|
||
if (turboScaleSession) { | ||
// remove unwanted path prefix for turboscale | ||
files = files.map((x) => { return path.join(testFolderPath, x.split(testFolderPath)[1]) }) |
Check warning
Code scanning / Semgrep OSS
Semgrep Finding: javascript.lang.security.audit.path-traversal.path-join-resolve-traversal.path-join-resolve-traversal Warning
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we are just trimming few path strings…removing prefix as we expect trimmed down path…
using path.join to be os agnostic.
|
||
exports.patchCypressConfigFileContent = (bsConfig) => { | ||
try { | ||
let cypressConfigFileData = fs.readFileSync(path.resolve(bsConfig.run_settings.cypress_config_file)).toString(); |
Check warning
Code scanning / Semgrep OSS
Semgrep Finding: javascript.lang.security.audit.path-traversal.path-join-resolve-traversal.path-join-resolve-traversal Warning
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no impact can be ignored. check above comment
} | ||
|
||
exports.atsFileCleanup = (bsConfig) => { | ||
const filePath = path.resolve(bsConfig.run_settings.patched_cypress_config_file); |
Check warning
Code scanning / Semgrep OSS
Semgrep Finding: javascript.lang.security.audit.path-traversal.path-join-resolve-traversal.path-join-resolve-traversal Warning
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no impact can be ignored. check above comment
Semgrep issue can be ignored and force merged as per slack thread - https://browserstack.slack.com/archives/CR42BQ3AQ/p1702374508668739?thread_ts=1702357970.975999&cid=CR42BQ3AQ |
https://browserstack.atlassian.net/browse/HST-722