Add default object for npm_dependencies #89

nagpalkaran95 · 2020-11-06T10:37:13Z

Fix for: run_settings.specs wasn't working for windows when npm_dependencies was not specified

bin/commands/runs.js

karanshah-browserstack

Rest LGTM

bin/commands/info.js

test/unit/bin/helpers/utils.js

Add default object for npm_depencies

72e9efd

nagpalkaran95 changed the title ~~Add default object for npm_depencies~~ Add default object for npm_dependencies Nov 6, 2020

move the func to utils

e03b496

karanshah-browserstack reviewed Nov 6, 2020

View reviewed changes

bin/commands/runs.js Outdated Show resolved Hide resolved

karanshah-browserstack requested changes Nov 6, 2020

View reviewed changes

bin/commands/runs.js Outdated Show resolved Hide resolved

nagpalkaran95 added 2 commits November 6, 2020 17:04

refactor

b03a873

update unit test cases

04a376e

karanshah-browserstack previously approved these changes Nov 6, 2020

View reviewed changes

bin/commands/info.js Show resolved Hide resolved

test/unit/bin/helpers/utils.js Show resolved Hide resolved

add unit test cases

8260d05

nagpalkaran95 dismissed karanshah-browserstack’s stale review via 8260d05 November 6, 2020 11:55

karanshah-browserstack approved these changes Nov 6, 2020

View reviewed changes

suryart approved these changes Nov 6, 2020

View reviewed changes

suryart merged commit 16ec8a2 into master Nov 9, 2020

suryart deleted the CYP_523_npm_dep branch November 9, 2020 11:33

Provide feedback