Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inject patches only in main testsuite html #66

Closed
jzaefferer opened this issue Apr 7, 2014 · 2 comments
Closed

Inject patches only in main testsuite html #66

jzaefferer opened this issue Apr 7, 2014 · 2 comments

Comments

@jzaefferer
Copy link
Contributor

Currently in server.js, any html file gets injected with the framework patch scripts. This approach causes issues when loading other html files, most likely as iframes.

This gist, running against the sizzle test suite, shows what happens in that case: https://gist.github.com/jzaefferer/401dd88e83443143d351 - its kind of obscure, but the lack of the window object led me to my conclusion above.

I've worked around this by only applying the patching to files called index.html. A proper solution should compare the filename to the one given in config.test_path. I'm not sure how to do that properly since test_path can be an array. Probably compare to each?

@jzaefferer
Copy link
Contributor Author

@rahulnwn hoping this can get addressed as well. I appreciate the other fixes.

@rahulnwn
Copy link
Contributor

Already working on it.

On Thu, Apr 10, 2014 at 9:16 PM, Jörn Zaefferer notifications@github.comwrote:

@rahulnwn https://github.com/rahulnwn hoping this can get addressed as
well. I appreciate the other fixes.

Reply to this email directly or view it on GitHubhttps://github.com//issues/66#issuecomment-40101790
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants