introducing browserstack-sdk to the sample repo #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ignore log files Add local test update
kamal-kaur04
requested changes
Dec 1, 2022
need appium fix for screenshot appium/java-client#1783
Upgraded to w3c. |
kamal-kaur04
requested changes
Dec 2, 2022
There was a problem hiding this comment.
Keep single runner file as in w3c branch - https://github.com/browserstack/testng-appium-app-browserstack/tree/w3c/android/testng-examples/src/test/java/com/browserstack
ios/testng-examples/src/test/java/com/browserstack/run_first_test/AppiumTest.java
Outdated
Show resolved
Hide resolved
ios/testng-examples/src/test/java/com/browserstack/run_first_test/LocalTest.java
Outdated
Show resolved
Hide resolved
ios/testng-examples/src/test/resources/com/browserstack/run_first_test/local.testng.xml
Outdated
Show resolved
Hide resolved
kamal-kaur04
requested changes
Dec 20, 2022
android/testng-examples/src/test/java/com/browserstack/AppiumTest.java
Outdated
Show resolved
Hide resolved
kamal-kaur04
requested changes
Dec 20, 2022
kamal-kaur04
approved these changes
Dec 22, 2022
Co-authored-by: Avinash Bharti <90600575+avinash-bharti@users.noreply.github.com>
avinash-bharti
approved these changes
Jan 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
apk and ipa are committed in the repo... I don't know any other more elegant way to deal with that.
Local tests cases are the same as the one in the base repo. They seems to be based out of another apk and ipa file, so local tests fail (but still run). Please let me know if you know where we can find the proper apk and ipa for that local test to run, I'll be glad to update the contribution accordingly.