Skip to content

Commit

Permalink
Use firefox | firefox-esr as OR dep for .deb
Browse files Browse the repository at this point in the history 
Touches #103

Though note that currently Debian Stretch's Firefox version is 52,
which is not new enough for Browsh.
  • Loading branch information
@tombh
tombh committed Jul 11, 2018
1 parent b8d031e commit 24c4921
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions interfacer/src/.goreleaser.yml
View file
Expand Up @@ -35,6 +35,10 @@ nfpm:

dependencies:
- firefox
overrides:
deb:
dependencies:
'firefox | firefox-esr'

brew:
name: browsh
Expand Down

3 comments on commit 24c4921

@einarjh
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see from your commit message that firefox-esr isn't new enough for browsh, so wouldn't this change just trigger a lot of bug reports when people try to install browsh on debian, and then can't get it to run?

@tombh
Copy link
Member Author

@tombh tombh commented on 24c4921 Jul 11, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, could well be the case :(

The reason I decide to make the commit is to save me having to do it when ESR does eventually get updated.

Thanks :)

@einarjh
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair enough. It looks as though firefox-esr in stretch will be upgraded to ESR 60 some time during august/september. Is Firefox 60 new enough?

Ref: https://www.reddit.com/r/debian/comments/8lsgfe/when_will_firefox_esr_v60_be_available_in_debian_9/

Please sign in to comment.