Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parser cannot handle PGn notation of enPassant+checking #43

Closed
Diceling opened this issue Nov 12, 2020 · 4 comments
Closed

Parser cannot handle PGn notation of enPassant+checking #43

Diceling opened this issue Nov 12, 2020 · 4 comments
Assignees
@brozeph
Milestone
v0.4.6

Comments

@Diceling
Copy link

When attempting to parse the attached PGN file, the move "gxf3+" could not be parsed properly.

Parser reduces it to "gf3" instead of "f3", which is in the list of available moves. Likely because it is also a checking move (hence the +).

Gibraltar2019-justfailinggame.txt
Gibraltar2019.txt
Screenshot 2020-11-12 at 01 37 17
@brozeph brozeph self-assigned this Nov 30, 2020
@brozeph brozeph added this to the v0.4.6 milestone Nov 30, 2020
brozeph added a commit that referenced this issue Nov 30, 2020
@brozeph
adding types for autocomplete as suggested in #45 and adding test wit…
c321d2d 
…h fix for defect in #43
@brozeph brozeph mentioned this issue Nov 30, 2020
Merged
@brozeph
Copy link
Owner

brozeph commented Dec 1, 2020

@Diceling thank you for this excellent defect report! Fixed in v0.4.6 - added a unit test and verified the fix using the game you posted!

@brozeph brozeph closed this as completed Dec 1, 2020
@Piterden
Copy link
Collaborator

Piterden commented Dec 3, 2020

btw, guys https://gist.github.com/Piterden/09626af18e0019a72e42b5216e935f59

@brozeph
Copy link
Owner

brozeph commented Dec 3, 2020

Awesome, @Piterden!

@Piterden
Copy link
Collaborator

Piterden commented Dec 3, 2020

Need to improve assertion a bit. Take a look maybe you have any ideas?

@rayfranco rayfranco mentioned this issue Jan 12, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brozeph brozeph

Labels
None yet
Projects
None yet
Milestone
v0.4.6
Development

No branches or pull requests
3 participants
@brozeph @Diceling @Piterden