This repository has been archived by the owner on Nov 21, 2018. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1
Added 2 templates #1
Open
eecollante10
wants to merge
12
commits into
brrd:master
Choose a base branch
from
eecollante10:patch-1
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added html and json template files for strapdownMenu template
Added css and js files to assets of strapdownMenu template
Added html and son template files for strap down template
Hi, I'm sorry, I really don't understand why you are using strapdown.js here?
Some other remarks:
I'm sorry but I won't merge this unless you do a substantial clean up of this code. |
What do you mean by: Please use clear and explicit names in menu labels. |
Personally I don't find "Md With Menu template" name very clear. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added two templates which use strapdown js.
The strapdownMenu one adds a menu on the top left with links to places on the document.