Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dataDWD: should dbin default be TRUE? #20

Closed
brry opened this issue Jul 6, 2020 · 1 comment
Closed

dataDWD: should dbin default be TRUE? #20

brry opened this issue Jul 6, 2020 · 1 comment
Labels

Comments

@brry
Copy link
Owner

brry commented Jul 6, 2020

Consider the implications of setting the default call to download.file with wb=TRUE

https://bookdown.org/brry/rdwd/raster-data.html#binary-file-errors

@adamhsparks
Copy link

Saw this on the R-pkg-devel list.

Yes, you want to do this. Otherwise, it won't properly work on Windows as you've noted. It bit me in https://github.com/ropensci/GSODR as I use macOS or Linux and forgot to set this for binary downloads.

@brry brry added the question label Jul 20, 2020
brry added a commit that referenced this issue Apr 8, 2021
@brry brry closed this as completed Apr 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants