This repository has been archived by the owner on Aug 16, 2021. It is now read-only.
Fixup matching, disallow repeating "types" (closes #23) #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is actually not a problem to have repeating instances of `links`, `foreign_links` and `errors`, the items will just be appended. To handle the zero-or-one rule for `types`, we can get away with just one new matching rule, because there are three cases (no types, empty types, and fully specified types).
|
Thanks! |
brson
added a commit
that referenced
this pull request
Aug 9, 2016
Fix stable tests after merge of #26
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is actually not a problem to have repeating instances of
links,foreign_linksanderrors, the items will just be appended.To handle the zero-or-one rule for
types, we can get away with justone new matching rule, because there are three cases (no types, empty
types, and fully specified types).