Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle SDL errors and fix segfaults #159

Merged
merged 2 commits into from
Feb 25, 2015
Merged

Handle SDL errors and fix segfaults #159

merged 2 commits into from
Feb 25, 2015

Conversation

lgrz
Copy link
Collaborator

@lgrz lgrz commented Feb 12, 2015

Submitting this one as a PR, it includes breaking changes to the existing API:

get_drive_name and get_joystick_name may call SDL_SetError so the return type of these functions was changed from String to Restult<String, String>.

If there is anything wrong with these changes or if you have better suggestions, let me know.

This breaks the existing API, `get_joystick_name`
and `get_drive_name` return the `Result` type for
handling errors.
The pointers returned from `SDL_WM_GetCaption`
may be null in some cases and if either one is
null an empty string is returned.
@lgrz
Copy link
Collaborator Author

lgrz commented Feb 24, 2015

Ok I'll merge this one in. It turns out the latest changes 3bb9ef6 fix the segfault with get_key_name so that has been removed.

lgrz pushed a commit that referenced this pull request Feb 25, 2015
Handle SDL errors and fix `SDL_WM_GetCaption`
@lgrz lgrz merged commit b5c49a6 into brson:master Feb 25, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant