-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow whitespace after colon in pairs #4
Comments
github's search handles terms without spaces. eg. but fails if it has spaces eg. |
I'm definitely not in favor of allowing a space after the colon. I haven't seen any similar query language that allows for that, and it just adds a lot of possible ambiguity and confusion. |
@deepak, thanks for your input on the project. In this case I tend to agree with @eric. I'd feel differently if I've seen it in the wild -- and a cursory look at GMail's interface (notable because keyword_search was originally modeled after it) shows it has the same restriction (eg, If I wanted to support this format in my own applications, I'd probably attempt to normalize user input before parsing with keyword_search; otherwise I'd try to make the expected format clear to my users as GMail does here: https://support.google.com/mail/answer/7190?hl=en |
can we parse something like. eg.
it has a space after the
:
we can parse without space as of now. eg.
modified the ragel file to something like
before looking at the forks
and found @makeitnew fork
makeitnew@c71705f#diff-ad07a259cc78956e22ff8e72d62d3925R60
it has
The text was updated successfully, but these errors were encountered: