Show 'svc -o' state in svstat output

[josb-ebaysf]

The prototype patch below adds displaying ', once' to the svstat output if svc -o /service/foo' is used instead ofsvc -u /service/foo'. Example:

# svc -u /service/rubygems/
# ./svstat /service/rubygems/
/service/rubygems/: up (pid 801) 4791279 seconds, running
# svc -o /service/rubygems/
# ./svstat /service/rubygems/
/service/rubygems/: up (pid 801) 4791288 seconds, running, once
# svc -u /service/rubygems/
# ./svstat /service/rubygems/
/service/rubygems/: up (pid 801) 4791294 seconds, running
#

Patch:

# git status
diff --git a/svstat.c b/svstat.c
index 03db0b8..09d2173 100644
--- a/svstat.c
+++ b/svstat.c
@@ -89,6 +89,8 @@ static void showstatus(const char status[19], int r, int normallyup)
     if (x)
       buffer_puts(&b,x);
   }
+  if (pid && (want == '\000'))
+    buffer_puts(&b,", once");
 }

 void doit(const char *dir)

As it stands, the unittest gives an error but should be easy to fix by changing it to support the svc -o' case in addition to thesvc -u' case.

# make
env - /bin/sh rts.sh 2>&1 | cat -v > rts
diff -u rts.exp rts
--- rts.exp 2013-10-14 16:50:05.051427273 -0700
+++ rts 2013-10-14 16:51:49.236428375 -0700
@@ -187,12 +187,12 @@
 100
 0
 --- svstat and svup work for logged services
-.: up (pid x) x seconds, normally down, running
-. log: up (pid x) x seconds, normally down, running
+.: up (pid x) x seconds, normally down, running, once
+. log: up (pid x) x seconds, normally down, running, once
 0
-.: up (pid x) x seconds, normally down, running
+.: up (pid x) x seconds, normally down, running, once
 0
-. log: up (pid x) x seconds, normally down, running
+. log: up (pid x) x seconds, normally down, running, once
 0
 0
 0
make: *** [rts] Error 1
#

What do you think?

[timbunce]

+1