Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove race conditions from tests #44

Closed
wants to merge 1 commit into from

Conversation

lechner
Copy link
Contributor

@lechner lechner commented Sep 5, 2017

Testing the qmqp protocol fails because the testing server cannot acquire the lock. This is solved by sleeping for one second so the previous server has time to exit and clear the lock. Also, sleep elsewhere before removing temporary directories.

Testing the qmqp protocol fails because the testing server
cannot acquire the lock.  This is solved by sleeping for
one second so the previous server has time to exit and
clear the lock. Also, sleep elsewhere before removing
temporary directories.
@bruceg
Copy link
Owner

bruceg commented Sep 28, 2017

I'm not sure I like sleeping to make sure a job exited (it's unavoidable when starting because services don't notify when they've started). Does adding a wait instead of sleep 1 resolve the issue for you?

@lechner
Copy link
Contributor Author

lechner commented Oct 3, 2017

Yes, wait works great. Will you please add them, or should I prepare a new pull request? Thank you!

@bruceg
Copy link
Owner

bruceg commented Oct 24, 2017

I've added wait instead of sleep myself now.

@bruceg bruceg closed this Oct 24, 2017
@lechner
Copy link
Contributor Author

lechner commented Oct 24, 2017

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants