Failing test – clear the right timeout

bruceharris · Dec 6, 2017 · e8e4dca · e8e4dca
1 parent da278c6
commit e8e4dca
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/src/components/LoadingIndicator.js b/src/components/LoadingIndicator.js
@@ -17,7 +17,7 @@ export default class LoadingIndicator extends Component {
   }
 
   componentWillUnmount() {
-    clearTimeout(this._delayTimer);
+    clearTimeout();
   }
 
   render() {

diff --git a/src/components/LoadingIndicator.test.js b/src/components/LoadingIndicator.test.js
@@ -51,6 +51,10 @@ describe('LoadingIndicator', () => {
   describe('on unmount', () => {
     it('should clear timeout', () => {
       jest.useFakeTimers();
+
+      const mockTimerValue = 12345;
+      setTimeout.mockReturnValue(mockTimerValue);
+
       const wrapper = mount(
         <LoadingIndicator isLoading={true}>
           <div>ahoy!</div>
@@ -59,6 +63,7 @@ describe('LoadingIndicator', () => {
 
       wrapper.unmount();
       expect(clearTimeout.mock.calls.length).toEqual(1);
+      expect(clearTimeout.mock.calls[0][0]).toEqual(mockTimerValue);
     });
   });
 });