Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pending Fedora 35 package does not build (new TeX Live?) #1565

Closed
flyn-org opened this issue Jul 12, 2021 · 16 comments
Closed

Pending Fedora 35 package does not build (new TeX Live?) #1565

flyn-org opened this issue Jul 12, 2021 · 16 comments

Comments

@flyn-org
Copy link
Contributor

I maintain the LaTeXML package for Fedora. The package just stopped building on (pre-release) Fedora 35, possibly due to the upgrade of TeX Live there. More information is available at https://bugzilla.redhat.com/show_bug.cgi?id=1969480.

Has anyone had success running the LaTeXML tests on TeX Live svn57862 or newer?

@dginev
Copy link
Collaborator

dginev commented Jul 12, 2021

Is the implication from Fedora that we need to keep a successfully building CI setup against the bleeding-edge of TeXlive?

We don't test specific svn variants, just the annual releases, and we tend to be quite slow/conservative with updating to newer ones at the moment.

expl3 regressing is indeed indicative that the newest texlive may have moved beyond latexml's currently implemented support for LaTeX 3.

@flyn-org
Copy link
Contributor Author

@dginev, I am not sure a successfully-building CI setup against the bleeding-edge of TeX Live is necessary, although it might be helpful. I am the maintainer, so it is my responsibility to alert you if something goes awry as it did here. Packagers such as I prefer fixing issues upstream, but sometimes we patch things to get them to work temporarily. As you probably know, Fedora is more aggressive than some other distributions at pursuing the latest packages, so this kind of thing happens.

@dginev
Copy link
Collaborator

dginev commented Jul 12, 2021

Got it, thanks for letting us know right away @flyn-org , much appreciated! And of course thanks for continuing to maintain the package, that's super helpful.

@dginev
Copy link
Collaborator

dginev commented Jul 12, 2021

Actually @flyn-org now that I searched for for the messages properly, this has been patched in #1454 and should work reliably in the latest latexml master. So... Would the preferred solution on our end be to ship a new release of latexml? Unsure how to best tackle that.

@flyn-org
Copy link
Contributor Author

I am always happy to package a new version, if you are ready for that. Otherwise, I can backport the patches to allow things to work on the forthcoming release of Fedora. I will do the latter now, and I will package a new release if you make one.

@flyn-org
Copy link
Contributor Author

flyn-org commented Jul 21, 2021

I was able to backport #1547. This fixed some of the errors, but the following remain:

Error:unexpected:undef Unexpected input remaining: 'undef'
	at xparse.sty.ltxml; line 19
	Finished reading from Mouth[/usr/share/texlive/texmf-dist/tex/latex/l3packages/xparse/xparse.sty@0x0], but it still has input.
	Input is empty
	In Core::Gullet[@0x2aa11047448] /builddir/build/BUILD/LaTeXML-0.8.5/blib/lib/LaTeXML/Package/xparse.sty.ltxml; line 19
	 <= Core::Definition::Constructor[\usepac... <= Core::Stomach[@0x2aa10ef9978] <= ...
Error:unexpected:T_CS[\NewDocumentCommand] Unexpected input remaining: 'T_CS[\NewDocumentCommand]'
	at xparse.tex; line 4 col 19 - line 4 col 19
	Finished reading from Mouth[/usr/share/texlive/texmf-dist/tex/latex/l3packages/xparse/xparse.sty@0x0], but it still has input.
	Next token is T_BEGIN[{]
	In Core::Gullet[@0x2aa11047448] /builddir/build/BUILD/LaTeXML-0.8.5/t/expl3/xparse.tex; from line 4 col 21 to line 4 col 21
	 <= Core::Definition::Constructor[\usepac... <= Core::Stomach[@0x2aa10ef9978] <= ...
Error:unexpected:<closed> Mouth is unexpectedly already closed
	at String; line 0 col 0 - line 0 col 0
	Reading from Mouth[/usr/share/texlive/texmf-dist/tex/latex/l3packages/xparse/xparse.sty@0x0], but it has already been closed.
	Input is empty
	In Core::Gullet[@0x2aa11047448] Anonymous String; from line 1 col 0 to line 1 col 0
	 <= Core::Definition::Constructor[\usepac... <= Core::Stomach[@0x2aa10ef9978] <= ...
Error:unexpected:<closed> Mouth is unexpectedly already closed
	at String; line 1 col 0 - line 1 col 0
	Reading from Mouth::Binding[/builddir/build/BUILD/LaTeXML-0.8.5/blib/lib/LaTeXML/Package/xparse.sty.ltxml], but it has already been closed.
	Input is empty
	In Core::Gullet[@0x2aa11047448] Anonymous String; from line 2 col 0 to line 2 col 0
	 <= Core::Definition::Constructor[\usepac... <= Core::Stomach[@0x2aa10ef9978] <= ...

@dginev
Copy link
Collaborator

dginev commented Jul 21, 2021

Thanks for following up @flyn-org !

The mention of \NewDocumentCommand in xparse points to our currently open issue #1566 and the suggest patch at #1569 . Thanks for letting us know this is a remaining issue to get the Fedora 35 package working, I think we should give the PR extra priority in that case, so that we get to some resolution. Will alert @brucemiller about that as well.

@flyn-org
Copy link
Contributor Author

I added the patch at #1569 to #1547, but I still received the error above when building.

@flyn-org
Copy link
Contributor Author

I was able to build on Fedora Rawhide (which will become Fedora 35) with the patch from #1578. Please see https://koji.fedoraproject.org/koji/taskinfo?taskID=72544751 for the result. So, I built a patched 0.8.5, and I will replace this with the next release once it is available. I will leave this issue open until the release.

Thank you @brucemiller and @dginev!

@xworld21
Copy link
Contributor

@flyn-org would you mind sharing which commits you decided to backport to Fedora? I am trying to do the same for nixpkgs (I cherry picked be20363, efb5776, b034118) but I am still getting errors. What else needs to go in?

@flyn-org
Copy link
Contributor Author

flyn-org commented Aug 2, 2021

I went the lazy route and pulled everything from master. I hope to package the next release soon, if it materializes.

@xworld21
Copy link
Contributor

xworld21 commented Aug 6, 2021

I went the lazy route and pulled everything from master. I hope to package the next release soon, if it materializes.

Right. It sounds like I'll have to do the same, the code has diverged too much from 0.8.5 for a simple backport.

@dginev
Copy link
Collaborator

dginev commented Aug 6, 2021

I went the lazy route and pulled everything from master. I hope to package the next release soon, if it materializes.

Right. It sounds like I'll have to do the same, the code has diverged too much from 0.8.5 for a simple backport.

Just to remark that this is quite appropriate, as we've been discussing shipping 0.8.6 quite soon - hopefully end of August.

@dginev dginev added this to the LaTeXML-0.8.6 milestone Aug 9, 2021
@dginev
Copy link
Collaborator

dginev commented Aug 26, 2021

This can stay pending in our next milestone actually, since it's an independent issue from latexml's release cycle, moving to 0.8.7.

@dginev dginev modified the milestones: LaTeXML-0.8.6, LaTeXML-0.8.7 Aug 26, 2021
@brucemiller
Copy link
Owner

What is actually "pending" here? My understanding was that essentially all the blockers in master were fixed, and that the issue was kept open simply as a pressure to release the darn thing so that it can be repackaged.

@dginev
Copy link
Collaborator

dginev commented Aug 26, 2021

@brucemiller ah, I assumed we're pending on the patched 0.8.5 making it into Fedora? Quote:

So, I built a patched 0.8.5, and I will replace this with the next release once it is available. I will leave this issue open until the release.

If I misunderstood and there's no work actually pending, we can close the issue - the 0.8.6 release has a milestone page, and doesn't need a reminder issue :>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants