Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SCNotifications need updating #253

Closed
vinsworldcom opened this issue Nov 3, 2022 · 0 comments · Fixed by #254
Closed

SCNotifications need updating #253

vinsworldcom opened this issue Nov 3, 2022 · 0 comments · Fixed by #254

Comments

@vinsworldcom
Copy link
Contributor

Discovered in #251 there are some SCNotifications that are missing returns and some are missing completely. The list:

A quick glance between the PythonScript 'Scintilla.h' (PythonScript\PythonScript\src\Scintilla.h), the Scintilla docs and the 'ScintillaWrapper.cpp' file yields this:

			case SCN_CHARADDED:
				params["ch"] = notifyCode->ch;
+				params["characterSource"] = notifyCode->characterSource;
				break;

			case SCN_USERLISTSELECTION:
+				params["ch"] = notifyCode->ch;
+				params["listCompletionMethod"] = notifyCode->listCompletionMethod;
				params["text"] = notifyCode->text;
				params["listType"] = notifyCode->listType;
                params["position"] = notifyCode->position;
				break;

			case SCN_AUTOCSELECTION:
+				params["ch"] = notifyCode->ch;
+				params["listCompletionMethod"] = notifyCode->listCompletionMethod;
				params["text"] = notifyCode->text;
                params["position"] = notifyCode->position;
				break;

+			case SCN_AUTOCSELECTIONCHANGE:
+				params["position"] = notifyCode->position;
+				params["text"] = notifyCode->text;
+				params["listType"] = notifyCode->listType;

+			case SCN_AUTOCCOMPLETED:
+				params["listCompletionMethod"] = notifyCode->listCompletionMethod;
+				break;

Cheers.

@chcg chcg closed this as completed in #254 Nov 4, 2022
chcg pushed a commit that referenced this issue Nov 4, 2022
* add missing SCNotification attributes (and fix spelling error "SCINTILLANOTFICATION"), fix #253

* fix spelling error in documentation

* update default case to include *all* parameters (as the comment indicates)
simplify cases for DWELLSTART/END and MARGRIN(RIGHT)CLICK as they are the same returns

* add some missing parameters to docs [skip ci]

Co-authored-by: VinsWorldcom <vin@vinsworld.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants