Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add conditionally colored PR timestamps #19

Merged
merged 7 commits into from
Apr 27, 2022

Conversation

SimonKienzler
Copy link
Collaborator

Uses human-readable timestamps via timeago.

Uses human-readable timestamps via timeago.
Copy link
Owner

@brumhard brumhard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall really great addition, thank you. I just have some minor comments.

app/lib/ui/colors.dart Show resolved Hide resolved
Copy link
Owner

@brumhard brumhard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mmh somehow this comment got lost in the last review

app/lib/ui/pr_card.dart Outdated Show resolved Hide resolved
app/lib/ui/colors.dart Outdated Show resolved Hide resolved
app/lib/ui/pr_card.dart Outdated Show resolved Hide resolved
app/lib/ui/pr_card.dart Outdated Show resolved Hide resolved
@brumhard brumhard merged commit 155226b into main Apr 27, 2022
@brumhard brumhard deleted the feature/conditional-time-colors branch April 27, 2022 15:37
@brumhard
Copy link
Owner

@SimonKienzler sry for the delay, and thank you for the great addition 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants