Fix issue #4 issue #12 and issue #15

.github/workflows/build.yml

@@ -16,7 +16,7 @@ jobs:
       env:
         GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
 
-    - uses: actions/checkout@v1
+    - uses: actions/checkout@v3
     - name: submodule update
       run: git submodule update --init
     - name: make vst3

Source/GuitarixEditor.h

@@ -139,6 +139,11 @@ class PresetSelect: public juce::ComboBox
             rightClick();
             return;
         }
+        juce::ComboBox::mouseDown(e);
+    }
+
+    void mouseDown (const juce::MouseEvent& e) override {
+        return;
     }
 
 private:

Source/JuceUiBuilder.cpp

@@ -49,6 +49,20 @@ const char* get_label(const char *sw_type) {
 
 // get host context Menu on right click if available
 
+void AutoComboBox::mouseUp (const juce::MouseEvent& e)
+{
+    if (e.mods.isRightButtonDown()) {
+        ed->getParameterContext(id);
+        return;
+    }
+    juce::ComboBox::mouseDown(e);
+}
+
+void AutoComboBox::mouseDown (const juce::MouseEvent& e)
+{
+    return;
+}
+
 void AutoSlider::mouseUp (const juce::MouseEvent& e)
 {
     if (e.mods.isRightButtonDown())
@@ -173,6 +187,7 @@ void JuceUiBuilder::create_slider(const char *id, const char *label, juce::Slide
 
     AutoSlider *s = new AutoSlider(label, ed, id);
     s->setComponentID(id);
+    //s->set_color(ed->get_component_color());
     s->setSliderStyle(style);
     s->setTextBoxStyle(juce::Slider::TextBoxBelow, false, 40, texth);
     //s->setPopupDisplayEnabled(true, false, ed);
@@ -363,7 +378,7 @@ void JuceUiBuilder::create_fload_button(const char *id, const char *label, int w
 
 void JuceUiBuilder::create_combo(const char *id, const char *label) {
 	if (inHide) return;
-	juce::ComboBox *c = new juce::ComboBox();
+	AutoComboBox *c = new AutoComboBox(ed, id);
 	lastcombo = c;
 
 	gx_engine::Parameter *p = ed->get_parameter(id);

Source/JuceUiBuilder.h

@@ -24,6 +24,8 @@
 
 class PluginEditor;
 
+//==============================================================================
+
 class VerticalMeter : public juce::Component
 {
 public:
@@ -46,6 +48,21 @@ class VerticalMeter : public juce::Component
 	float level = -60.f;
 };
 
+class AutoComboBox : public juce::ComboBox
+{
+public:
+    AutoComboBox(PluginEditor *ed_, const char* id_)
+    : ed (ed_), id (id_), juce::ComboBox(){}
+
+    void mouseUp (const juce::MouseEvent& e) override;
+    void mouseDown (const juce::MouseEvent& e) override;
+
+private:
+    PluginEditor *ed;
+    const char* id;
+    JUCE_DECLARE_NON_COPYABLE_WITH_LEAK_DETECTOR(AutoComboBox)
+};
+
 class AutoButton : public juce::ToggleButton
 {
 public:

Source/PluginEditor.cpp

@@ -692,6 +692,8 @@ void PluginEditor::paint(juce::Graphics& g)
 {
     // (Our component is opaque, so we must completely fill the background with a solid colour)
     g.fillAll(col);
+    g.setColour(col.darker());
+    g.drawRect(getLocalBounds(), 3);
 
     /*
     g.setColour(juce::Colours::white);

Source/PluginEditor.h

@@ -46,6 +46,26 @@ class MuteButton : public juce::ToggleButton
     JUCE_DECLARE_NON_COPYABLE_WITH_LEAK_DETECTOR (MuteButton)
 };
 
+class PlugSelect: public juce::ComboBox
+{
+public:
+    PlugSelect() : juce::ComboBox() {}
+
+    void mouseUp(const juce::MouseEvent& e) override {
+        if (e.mods.isRightButtonDown()) {
+            return;
+        }
+        juce::ComboBox::mouseDown(e);
+    }
+
+    void mouseDown (const juce::MouseEvent& e) override {
+        return;
+    }
+
+private:
+    JUCE_DECLARE_NON_COPYABLE_WITH_LEAK_DETECTOR (PlugSelect)
+};
+
 class ParListener
 {
 public:
@@ -74,6 +94,7 @@ class PluginEditor: public juce::Component,
 	void addControl(juce::Component *c, juce::Component* parent = 0);
 	gx_engine::Parameter* get_parameter(const char* parid);
     gx_engine::GxMachine *get_machine();
+    juce::Colour& get_component_color() { return col;}
 
 	const char* getID() const { return pid.c_str(); }
 //	int edx, edy;
@@ -130,7 +151,7 @@ class PluginSelector : public juce::Component,
 
 	MachineEditor *ed;
 	PluginEditor *ped;
-	juce::ComboBox combo;
+	PlugSelect combo;
 	MuteButton mute;
 	juce::TextButton add, remove;