Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flush the input buffer when we leave input mode but found nothing #15

Closed
fangpenlin opened this issue Jan 8, 2016 · 4 comments
Closed

Comments

@fangpenlin
Copy link
Contributor

When you type something like this

:)

and press ESC or enter, it would be nice to flush the input buffer instead of reset it

@fangpenlin
Copy link
Contributor Author

Thought about this feature, ESC is for cancelOperation command, and it usually means user wanting to cancel the operation literally, so I think it's better to drop the input buffer.

Instead, when you press Enter, that means you want to submit it. So I change the key to Enter instead.

/cc @lg

fangpenlin added a commit that referenced this issue Jan 9, 2016
…fer-for-enter

Fix #15, press enter to flush input buffer
@lg
Copy link

lg commented Jan 9, 2016

hm. i'm pressing ESC to close the dialog and keep the ":)" that i already typed. i think ESC would make sense here. what about both ESC an Enter?

@fangpenlin
Copy link
Contributor Author

@lg yo, problem fixed 😎

@lg
Copy link

lg commented Feb 7, 2016

:) :) :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants