New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
no need to "float" items #1
Comments
Why is it a bad practice? I do not see the point. The performance of floats is even a little better: https://github.com/mdo/css-perf#grid-techniques. |
float's need to be cleared, and floats cannot be centered. If you think about it, In another subject, what would be the performance of your gallery when dealing with thousands of items? The javascript is not designed to handle large amounts of items, since there no optimizations for performance..the key is to cache items, access the DOM as few times as possible and consider bulk updating and replacing the whole container's html every time. also it's very important to NOT use jQuery where ever possible, since it's very slow.
I want to say that I really love your plugin, it's really, truly, a good one! |
Thanks yairEO, I appreciate your advices. |
FYI the plugin does not require a float grid system you can also use |
Using floats (in this manner) is considered bad practice. Please use
inline-block
and if your HTML is not minified, then you will have to hack the container withfont-size:0
.The text was updated successfully, but these errors were encountered: