Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LPS-85359 SF #939

Closed
wants to merge 159 commits into from
Closed

LPS-85359 SF #939

wants to merge 159 commits into from

Conversation

alinedoleron
Copy link

No description provided.

kmaria and others added 30 commits October 8, 2018 08:53
@brianchandotcom
LRQA-43947 Update path for scheduling publication
9c5a736
@brianchandotcom
LPS-84399 Update master bnd.bnd now that uad is in 7.0.x
be9d2a0
@brianchandotcom
LPS-85641 Fix bnd.bnd
335b5ce
@arboliveira @brianchandotcom
LPS-84665 portal-search: build.gradle: Indirect dependencies required…
cf9b01d 
… for ant-less "gradlew test"

https://issues.liferay.com/browse/LPS-84665
https://issues.liferay.com/browse/LPS-84666
@arboliveira @brianchandotcom
LPS-84665 portal-search-web: build.gradle: Indirect dependencies requ…
d9e8674 
…ired for ant-less "gradlew test"

https://issues.liferay.com/browse/LPS-84665
https://issues.liferay.com/browse/LPS-84666
@arboliveira @brianchandotcom
LPS-84665 portal-search-test-util: Tests: assetTagNames* fields alw…
15278e5 
…ays language aware now, so test them as such

- Word stemming makes recall wider
- Stopwords wholly out of tokenization

https://issues.liferay.com/browse/LPS-84665
https://issues.liferay.com/browse/LPS-84666
@arboliveira @brianchandotcom
LPS-84665 portal-search-elasticsearch6-impl: Tests: assetTagNames* …
1905906 
…fields always language aware now, so test them as such

- Word stemming makes recall wider
- Stopwords wholly out of tokenization

https://issues.liferay.com/browse/LPS-84665
https://issues.liferay.com/browse/LPS-84666
@shuyangzhou @brianchandotcom
LPS-86092 We only have one module config, construct, init and use the…
8f86986 
… PortalRequestProcessor explicitly.
@shuyangzhou @brianchandotcom
LPS-86092 No one is using those callParent* methods
7781d8a
@shuyangzhou @brianchandotcom
LPS-86092 Inline addPaths()
caa6379
@shuyangzhou @brianchandotcom
LPS-86092 Inline super.init()
7e52e54
@shuyangzhou @brianchandotcom
LPS-86092 Bring in super.processPath()
7e726ae
@shuyangzhou @brianchandotcom
LPS-86092 Inline super.processPopulate()
0f878e2
@shuyangzhou @brianchandotcom
LPS-86092 We never use this feature
d3a2511
@shuyangzhou @brianchandotcom
LPS-86092 Bring in super.process()
04b1f3c
@shuyangzhou @brianchandotcom
LPS-86092 These are known to be doing nothing.
9f17ca8
@shuyangzhou @brianchandotcom
LPS-86092 Bring in super.processLocale()
289dcab
@shuyangzhou @brianchandotcom
LPS-86092 Bring in super.processContent()
5906fb9
@shuyangzhou @brianchandotcom
LPS-86092 Bring in super.processNoCache()
99e32dc
@shuyangzhou @brianchandotcom
LPS-86092 Bring in super.processCachedMessages()
a513010
@shuyangzhou @brianchandotcom
LPS-86092 Bring in super.processMapping()
b9ada88
@shuyangzhou @brianchandotcom
LPS-86092 Bring in super.processActionForm()
a8d3097
@shuyangzhou @brianchandotcom
LPS-86092 Bring in super.processValidate()
ed86d23
@shuyangzhou @brianchandotcom
LPS-86092 We never use this feature
774d8a5
@shuyangzhou @brianchandotcom
LPS-86092 Bring in super.processActionPerform()
e8525c9
@shuyangzhou @brianchandotcom
LPS-86092 Bring in super.processException()
a30fa35
@shuyangzhou @brianchandotcom
LPS-86092 Bring in super.processForward()
2bd6623
@shuyangzhou @brianchandotcom
LPS-86092 Bring super.processInclude()
19384e0
@shuyangzhou @brianchandotcom
LPS-86092 Bring in super.processActionCreate()
b3a1f3c
@shuyangzhou @brianchandotcom
LPS-86092 Inline super.getServletContext()
aa8eb75
Bruno Basto and others added 22 commits October 8, 2018 17:25
@aline-doleron
LPS-85359 Updates snapshots
51e4aff
@aline-doleron
LPS-85359 Avoid starting a build during another build
3f67422
@aline-doleron
LPS-85359 Adds tests for acceptance criterias
7ffcb22
@aline-doleron
LPS-85359 Fix broken tests
ee7ae70
@aline-doleron
LPS-85359 Update test snapshots
bcd2446
@aline-doleron
LPS-85359 SF
cc5b963
@aline-doleron
LPS-85359 Organize tests
56edfd5
@aline-doleron
LPS-85359 Update snapshots
9eb5102
@aline-doleron
LPS-85359 Rename from add-condition to class add-item
b794676
@aline-doleron
LPS-85359 Handle cases of selecting a number
4a37f80
@aline-doleron
LPS-85359 Handle initial case of duplicating a condition
a1b6c1f
@aline-doleron
LPS-85359 Clear second operand type after changing the first operand …
567ea11 
…value
@aline-doleron
LPS-85359 Show selection when field has options
93bdf32
@aline-doleron
LPS-85359 Update tests
f88f45f
@aline-doleron
LPS-85359 SF
ef2eaaf
@aline-doleron
LPS-85359 update snapshots
831157c
@aline-doleron
LPS-85359 Adjust add button position
4b95187
@aline-doleron
LPS-85359 Do not clear second operand type value
9a0401a
@aline-doleron
LPS-85359 Add test to check if second operand type is not cleared aft…
cf89dc2 
…er changing from form to rules
@aline-doleron
LPS-85359 Add test
2f92fc9
@aline-doleron
LPS-85359 Check if second operand is cleared after change type
0264db9
@aline-doleron
LPS-85359 SF
cd2627f
@liferay-continuous-integration
Copy link
Collaborator

To conserve resources, the PR Tester does not automatically run for every pull.

If your code changes were already tested in another pull, reference that pull in this pull so the test results can be analyzed.

If your pull was never tested, comment "ci:test" to run the PR Tester for this pull.

@alinedoleron alinedoleron mentioned this pull request Oct 8, 2018
Closed
@brunobasto
Copy link
Owner

Just started reviewing :)

:octocat: Sent from GH.

@brunobasto
Copy link
Owner

Pull request submitted to brianchandotcom#63907. See changes here.

:octocat: Sent from GH.

@brunobasto brunobasto closed this Oct 8, 2018
@brunobasto
Copy link
Owner

Pull request submitted to brianchandotcom#63908. See changes here.

:octocat: Sent from GH.

@brunobasto
Copy link
Owner

Pull request submitted to brianchandotcom#63912. See changes here.

:octocat: Sent from GH.

@alinedoleron alinedoleron deleted the pr-938 branch March 2, 2021 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone