Added 12 hour format option to clock

[AkBKukU]

Here are the changes I had made to the clock screen to make the 12 hour option.

Added:

• Characters m, p, & a to digmap
• Format (-f) argument to use 12 hour clock
• If series to calculate 12 hour characters

[AkBKukU]

Cool! As I had mentioned earlier this is my first time using python and the indents were giving me problems. I'm not used to the idea of the code needing to be indented for any reason other than readability.

I was indecisive when choosing the argument character. I just used format because it was the first thing I thought of when considering the difference.

This is also my first time using Github. I noticed the missing line from the zero and that there are commit comments after I had committed but I didn't know how to change the upload. I also hadn't intended on removing the seconds when I uploaded the code, I did it to the clock.py I'm running and I copied that and forgot to change it back.

I noticed that you changed most of the hour code and that it looks much simpler. I am not aware of the "modulus" operator but after seeing the difference I will be looking into it!

I'm glad I was able to make a useful contribution! You can add my name(Shelby Jueden) to the list.

[brunobraga]

Yeah, it is weird to worry much about indentation in the beginning, but you will get used to it... it's not that bad.

Github (Git for that matter) is very powerful, which tends to get a bit confusing... for what you are talking, as long as you did not push the code yet (hold commits locally), you could --amend to the commit. Otherwise, just edit the file again and commit/push again. One more commit won't harm.

Sorry for messing it up your code a bit. Hope you don't mind... just trying to keep things standard with the previous code. You will notice that, when helping out open-source code, you kind a need to study the source and learn its practices, rules, etc... some code out there get very picky over things like comments or variable naming... doesn't mean they are the best or right, just that we need to follow the standard that the code is using... so as long we understand that, it saves a lot of hassle for pushing one's commits into someone else's code...

Thank you for your contribution. I will add your name to the debian/copyright note, as recommended by packaging standards.

If you are interested in helping out more, go for it!
I have some interesting "plugins" for it:

• Issue Implement figlet based screensaver #2 - figlets
• Issue Implement image viewer screensaver #12 - jp2a (to encode images in ASCII format)
• Issue Add StarWars Asciimation as screensaver option #9 - star wars animation

These are nearly completed, but any other suggestions are welcome. The idea behind plugins is to allow installation of external software outside of the boundaries of termsaver (I want to leave this in pure python for platform compatibility). So for instance, termsaver-figlet plugin will only be available in Linux, unless you compile figlet and then the plugin yourself in Mac or Windows.

Cheers,

[brunobraga]

Hei,

Done. Added your name, commit b308913.

Cheers,

[AkBKukU]

Cool, thank you.
My classes just started but I have a couple more ideas I'd like to try and make. I'll see when I get some time to work on them.