-
Notifications
You must be signed in to change notification settings - Fork 17
Support for html-webpack-plugin 4? #128
Comments
The html-webpack-plugin is already following a webpack recommendation to increase the hook performance: webpack/webpack#7673 A static version property was added for direct access: The new event name and timing can be seen in this chart: However as the html-webpack-plugin is an optional dependency you will probably need some "optional require" like the webpack-subresource-integrity plugin did: Could you please give the new events a try and let me know if they work for your case?
|
@jantimon Thanks a lot for the pointers Actually t wasn't too hard, so I went ahead and added support to v4 already. Do you think you could check whether #131 works for you and let me know before I merge it? |
Hey @brunocodutra any news on this? Any way I can help? |
PR #131adds support for it, do you think you could test it and let me know if it works for you? |
Sure! Do I need to build the project or I can just drop-in replace it in the |
You should be able to use the repo url (including the branch) in place of the version string in package.json |
Hey @brunocodutra can confirm it works flawlessly for me! |
It's still not out quite yet, but I'm using html-webpack-plugin 4.0.0-alpha.2 for performance reasons. I can't seem to get this plugin working with it, so I'm guessing it's not supported. The integration API has changed considerably:
jantimon/html-webpack-plugin#953
If you could support both versions, that would be much appreciated.
Cheers!
The text was updated successfully, but these errors were encountered: