Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gemfile, .rspec and Yarn updates #10

Merged
merged 6 commits into from
Sep 29, 2017

Conversation

malachaifrazier
Copy link
Contributor

  1. Several Gem version updates
  2. Updated .rspec to display more info
  3. upgraded Yarn
  4. Updated .ruby-version to use 2.2.5

@brunofacca
Copy link
Owner

Thanks for your contribution :)

If you don't mind, I'd like to know more about a few of your choices.

Any specific reason for leaving both pg and mysql2 uncommented in the Gemfile?

Why Ruby 2.2.5 in .ruby-version? I think specifying a Ruby version is a good idea, but then we should probably use the latest stable version (2.4.2). What do you think?

Why list Ruby 2.5 as a dependency in README.md? The current stable version is 2.4.2.

Why modify schema.rb?

Thanks again.

@malachaifrazier
Copy link
Contributor Author

Whoopsie. The pg and mysql gems being uncommented was an oversight on my part.
You're absolutely correct about the ruby version...by bad.
The schema modification happened automatically when I bundle install, so we can consider it trivial?

Fixing all the things now.

@brunofacca brunofacca merged commit 1247c1a into brunofacca:master Sep 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants