Fix for LibreSSL/OPENSSL_NO_COMP #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The related issue: #29 |
| p_ssl ssl = (p_ssl)luaL_checkudata(L, 1, "SSL:Connection"); | ||
| if (ssl->state != LSEC_STATE_CONNECTED) { | ||
| lua_pushnil(L); | ||
| lua_pushstring(L, "closed"); | ||
| return 2; | ||
| } | ||
|
|
||
| #if !defined(OPENSSL_NO_COMP) | ||
| const COMP_METHOD *comp; |
There was a problem hiding this comment.
For strict compiles, the declaration must be at the top of the function.
brunoos
added a commit
that referenced
this pull request
Jan 28, 2015
Fix for LibreSSL/OPENSSL_NO_COMP
jow-
added a commit
to jow-/packages
that referenced
this pull request
Aug 9, 2016
Currently luasec fails to build if OpenSSL was built without compression
support due to an undefined COMP_METHOD type:
ssl.c: In function 'meth_compression':
ssl.c:404:9: error: unknown type name 'COMP_METHOD'
const COMP_METHOD *comp;
^
<builtin>: recipe for target 'ssl.o' failed
make[6]: *** [ssl.o] Error 1
Add a local patch to stub the `meth_compression()` function if there is no
compression support available in the OpenSSL library in order to allow
luasec to build.
A similar fix has been added upstream with
lunarmodules/luasec#30
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.