Skip to content

Commit

Permalink
Update comparison
Browse files Browse the repository at this point in the history
  • Loading branch information
brunorijsman committed Feb 14, 2020
1 parent bf041c4 commit 5713e75
Show file tree
Hide file tree
Showing 2 changed files with 41 additions and 3 deletions.
17 changes: 14 additions & 3 deletions docs/source/comparison-conclusions.rst
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,18 @@ Standard deviation.

The graphs in the original papers do not have any indication of the standard deviation (i.e. no error bars). We have that information for all experiments, although we don't show it in all graphs - we omit it if it would make the graph too noisy.

Missing slow decrease in channel uses.
--------------------------------------
Differences in the detailed shape of the channel use graph.
-----------------------------------------------------------

The figures reported in the literature show that the number of channel uses first sharply increases as the bit error rate increases from 0.00 to 0.30. After that the number of channel uses slowly decreases again. We don't see this latter slow decrease in our results. I currently have no explanation for this difference.
In many respects, most of my reproduced channel use figures match the figures in the original literature quite well. The overall shape matches quite well. The numerical value matches quite well. And the appearance of saw-tooth patterns matches quite well.

In some other aspects, however, there are some striking differences between the original and reproduced channel use figures as well.

In some of the figures in the original literature (e.g. figure 2 in the demystifying paper) the channel uses graph clearly slopes down as the error rate increases. In my reproduced figures, this downward slope is missing.

In other figures in the original literature (e.g. the black and green graphs in figure 9 in the demystifying paper) we see a "wave" pattern on top of the "saw tooth" pattern. This "wave" pattern is missing in my reproduced graphs.

Channel use graph for Cascade opt. (2) is different.
----------------------------------------------------

The original channel use graph for algorithm "Cascade opt. (2)" is quite different from the reproduced graph: the original values are higher and have much more wildly swinging saw-teeth.
27 changes: 27 additions & 0 deletions docs/source/comparison.rst
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,14 @@ Reproduced figure from this code:
.. image:: figures/demystifying-figure-5-reproduced.png
:align: center

Once again, the reproduced figure is mostly useless, for similar reasons to figure 4.

Due to the slow Python code, we only did 1,000 (10^3) iterations per data point. For key size 1,000 (10^3) this means we cannot bit error rates below 10^-6. And for key siz 10,000 (10^4) this means we cannot detect bit error rate below 10^-7.

As expected, the reproduced figure 5 falls apart below these 10^-6 (black line) and 10^-7 (blue line) bit error rates.

Again, hopefully, when we have a faster C++ implementation we will be able to run more iterations per data point and hence study lower error rates.

Figure 6
--------

Expand Down Expand Up @@ -131,6 +139,10 @@ Reproduced figure from this code:
.. image:: figures/demystifying-figure-8-reproduced.png
:align: center

The original and the reproduced figure match very well.

Once again, the original graph has more detail because they executed more runs per data point.

Figure 9
--------

Expand All @@ -144,6 +156,21 @@ Reproduced figure from this code:
.. image:: figures/demystifying-figure-9-reproduced.png
:align: center

There are few noticeable differences between the original figure and the reproduced figure.

There is of course the fact that the original figure has more detail than the reproduced figure, because we run fewer iterations per data point.

The black, green, and blue graphs match reasonably well in the original and the int reproduced figure. They have very similar values and similar shapes including the obvious saw-teeth. There are a few differences in the details though.

We already observed the first difference in figure 2. In the original graph the blue graph clearly slopes down towards the end. In the reproduced graph the blue line saw-tooths around a flat trend instead of trend that slopes down.

In the green and the black graphs, we also see a difference. In the original graph we see a lower frequency secondary wave pattern on top of the higher frequency saw-teeth. For example, there are 6 "waves" in the green graph and lots of saw-teeth within each "wave". In the reproduced green and black graphs, we do not see these "waves".


The last and biggest difference is in the red graph. This graph is completely different in the original vs reproduced figure. In the original figure the red graph is much higher (above the blue graph) and has much bigger saw-teeth.

I currently do not have an explanation for any of these observed differences.

Figure 10
---------

Expand Down

0 comments on commit 5713e75

Please sign in to comment.