Pokemon Page improvements #326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added raid stats to pokemon page Added evolution tree (VIP)
|
I think the raid stuff will not work properly, because RM only stores the current raid for each gym. The evolution tree will maybe work also without a new file, because the candy requirements are stored in the pokedex file already. |
|
123FLO321
changed the title
Added cron to fix raid count
123FLO321
changed the title
|
I try to test it and the tree works without problems at all. And the raid too but i must wait to tomorrow for new raids. :D Nice Work. |
|
Result runs without Problems at me. |
|
looks really nice! +1 and I'll merge |
|
Tested and works fine! |
|
Please rebase :) |
|
done @Obihoernchen |
Obihoernchen
requested changes
Dec 8, 2017
|
|
||
| <div> | ||
| <a href="<?= $link ?>"><img src="<?= $tree_pokemon->img ?>" alt="<?= $tree_pokemon->name ?>" class="img"></a> | ||
| <p class="pkmn-name"><a href="<?= $link ?>">#<?= sprintf('%03d<br>%s', $tree_pokemon->id, $tree_pokemon->name) ?></a></p> |
There was a problem hiding this comment.
$link does not work if Worldopole is installed in a subdirecotry
3 tasks
|
Works fine! Great job! |
Obihoernchen
approved these changes
Dec 11, 2017
Obihoernchen
pushed a commit
that referenced
this pull request
Jan 21, 2018
rahciach
pushed a commit
to rahciach/Worldopole
that referenced
this pull request
Jan 26, 2018
* fix 241 evolution * fix arrow for 2nd evolutions * woops * fix tabs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added Pokemon Tree to Pokemon page
Added Raid count to Pokemon page
The Pokemon Tree is fully dynamic based on max pokemon id and also shows evolution items.
How Has This Been Tested?
On local instance and working perfectly
Screenshots (if appropriate):
Raid Count:
Tree:
Types of changes