Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gym InfoWindow arrow, encoding fixes and cleanup #99

Merged
merged 6 commits into from
Nov 16, 2016
Merged

Gym InfoWindow arrow, encoding fixes and cleanup #99

merged 6 commits into from
Nov 16, 2016

Conversation

Obihoernchen
Copy link
Collaborator

@Obihoernchen Obihoernchen commented Nov 16, 2016 •
edited
Loading

  • Add an Arrow with shadow + remove some stuff abd3d36 (Screenshot 1)
  • Fix encoding issues 9c815f4
  • Remove unused parameter d936028
  • Less margin 4bd1805 (Screenshot 2)
  • Remove "CP:" from trainer and gym infowindow. It looks more polished without. ad18c40 (Screenshot 2)

Screenshots

Arrow
image

+ all other improvements
image

Live

https://vserver.obihoernchen.net/pokemon_dev/gym

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

@Obihoernchen Obihoernchen changed the title Gym InfoWindow arrow, encoding fixes and xes Gym InfoWindow arrow, encoding fixes and cleanup Nov 16, 2016
@Obihoernchen Obihoernchen self-assigned this Nov 16, 2016
@Obihoernchen
Copy link
Collaborator Author

@PoUpA please review this 🙇‍♂️

@Obihoernchen Obihoernchen mentioned this pull request Nov 16, 2016
Closed
12 tasks
@Obihoernchen Obihoernchen merged commit ad18c40 into brusselopole:master Nov 16, 2016
@Obihoernchen
Copy link
Collaborator Author

ups... Didn't want to merge it xD
Whatever here we go 💃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Obihoernchen Obihoernchen

Labels
bug enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@Obihoernchen