Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

templating #35

Open
Dieterbe opened this issue Jul 14, 2014 · 3 comments
Open

templating #35

Dieterbe opened this issue Jul 14, 2014 · 3 comments

Comments

@Dieterbe
Copy link
Contributor

in graphite-web/webapp/graphite/render/glyph.py the method loadTemplate reads the template from the config file. graphite-api doesn't do this.

  • it has been the case since initial release, yet this is not mentioned anywhere in the changelog (i.e. implying that the behavior is the same as graphite-web).
  • the docs still mention the template http param and graphTemplates.conf, glyph.py also refers to the file, but the file is not used and the param does nothing.
@brutasse
Copy link
Owner

I'd be in favor of dropping the template-related code and document that graphite-api doesn't have templates and passing &template= is a no-op.

@Dieterbe
Copy link
Contributor Author

why? i would argue that templates are quite useful, and easy to implement.
do you think people should append all style parameters to every png url? that can get cumbersome.

Dieterbe pushed a commit to Dieterbe/graphite-api that referenced this issue Jul 16, 2014
support graph templates. fixes brutasse#35
6836990
Dieterbe pushed a commit to Dieterbe/graphite-api that referenced this issue Sep 2, 2014
support templates. fixes brutasse#35
b42f0d5 
similar to previous PR, except now it integrates into the
main yaml file instead of a separate graphTemplates.conf
Dieterbe pushed a commit to Dieterbe/graphite-api that referenced this issue Dec 14, 2014
support templates. fixes brutasse#35
a23c3a7 
similar to previous PR, except now it integrates into the
main yaml file instead of a separate graphTemplates.conf
vladimir-smirnov-sociomantic pushed a commit to vladimir-smirnov-sociomantic/graphite-api that referenced this issue Dec 30, 2014
@vladimir-smirnov-sociomantic
support templates. fixes brutasse#35
2b4662e 
similar to previous PR, except now it integrates into the
main yaml file instead of a separate graphTemplates.conf
bogus-py pushed a commit to bogus-py/graphite-api that referenced this issue Aug 27, 2015
@bogus-py
support templates. fixes brutasse#35
cd070e5 
similar to previous PR, except now it integrates into the
main yaml file instead of a separate graphTemplates.conf
@zzl0
Copy link

zzl0 commented Nov 16, 2016 •
edited

templates are quite useful

+1

zzl0 added a commit to zzl0/graphite-api that referenced this issue Nov 22, 2016
@zzl0
Support template to fix brutasse#35
55d4898
zzl0 added a commit to zzl0/graphite-api that referenced this issue Nov 22, 2016
@zzl0
Support template to fix brutasse#35
8484ddd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Dieterbe @brutasse @zzl0