Allow escaped and unescaped single and double quotes in metric names. #215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this -- looking at the same code in graphite-web, I don't see why graphite-api's behavior would be different than graphite-web's:
These seem to match what we have in graphite-api. Or did I miss something? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change would allow single and double quotes both escaped and unescaped in metric targets, with the goal of more closely matching the behavior of graphite-web, which allows both.
Not attached to the formulation of the below, just interested in the end results. I am using (and loving) graphite-api as a (much simpler!) graphite-web and this is the first notable discrepancy reported by our users.