Skip metrics with empty timestamp #83
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For some reason, I'm seeing timestamp, value tuples of (None, None) consistently as the last item in the list on returns from cyanite. Skip bad timestamps defensively. Signed-off-by: Stephen Gran <steve@lobefin.net>
|
yeah, that might be a good idea as well - I'm not sure why cyanite is returning (None, None) for the last array element, but it seems like a useful guard anyway. Up to you, though :) Cheers, |
|
@sgran there might be some misalignment between the (start, end, step) info and the number of datapoints passed (see zip_longest above your change). Do you still see this regularly? Can you try with the new cyanite (requires schema change)? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason, I'm seeing timestamp, value tuples of (None, None)
consistently as the last item in the list on returns from cyanite. Skip
bad timestamps defensively.
Signed-off-by: Stephen Gran steve@lobefin.net