-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
by default listens on port 5353 #23
Comments
I also looked around some other areas - the I've confirmed that removing it solves my hassles |
You are right. I also think it would be better to remove the default responder completely. |
cool, there's a PR ready then |
(#23) remove default listening responder
I am using your hc project in my choria.io project to do some IoT work and really loving it.
Unfortunately though due to this line:
dnssd/responder.go
Line 46 in 5bf037f
Even when
hc
is not enabled a mdns listener is started and active and talking to the network, this is not desired as I tend to run my software on very large server estates - 10s of thousands of nodes - all of them joining mDNS is a bit of a surprise :) I'd like to enable it only when configured to be enabled.Investigating further I cannot see anywhere where this
DefaultResponder
is used inhc
ordnssd
, would it be possible to either remove this line if its unused or turn it into something thats lazy started only when needed?I can send a PR with your guidance @brutella
thanks
The text was updated successfully, but these errors were encountered: