Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

by default listens on port 5353 #23

Closed
ripienaar opened this issue Dec 4, 2020 · 3 comments
Closed

by default listens on port 5353 #23

ripienaar opened this issue Dec 4, 2020 · 3 comments

Comments

@ripienaar
Copy link
Contributor

I am using your hc project in my choria.io project to do some IoT work and really loving it.

Unfortunately though due to this line:

var DefaultResponder, _ = NewResponder()

Even when hc is not enabled a mdns listener is started and active and talking to the network, this is not desired as I tend to run my software on very large server estates - 10s of thousands of nodes - all of them joining mDNS is a bit of a surprise :) I'd like to enable it only when configured to be enabled.

Investigating further I cannot see anywhere where this DefaultResponder is used in hc or dnssd, would it be possible to either remove this line if its unused or turn it into something thats lazy started only when needed?

I can send a PR with your guidance @brutella

thanks

@ripienaar
Copy link
Contributor Author

I also looked around some other areas - the DefaultResponder isn't used in any of your repos. It was added here 36a2d8c but even there this DefaultResponder was never used. Seems safe to me to just remove it.

I've confirmed that removing it solves my hassles

@brutella
Copy link
Owner

brutella commented Dec 7, 2020

You are right. I also think it would be better to remove the default responder completely.

@ripienaar
Copy link
Contributor Author

You are right. I also think it would be better to remove the default responder completely.

cool, there's a PR ready then

brutella added a commit that referenced this issue Dec 16, 2020
(#23) remove default listening responder
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants