When converting a date time where the time is '00:00:00' infer returns a date type instead of date time #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
January 13, 2018 21:33
Remove if dt.time() to avoid convenrting timestampsat midnight to dates
…and added 3.5 check
…times Do not use dupers on py > 3.5 and add extra timezone conversions
|
@bruth could you have a look into my pull request please? |
bruth
requested changes
Jan 14, 2018
| @@ -1,11 +1,15 @@ | |||
|
|
|||
strconv.py
Outdated
| from datetime import datetime | ||
| import re | ||
|
|
||
| import sys |
There was a problem hiding this comment.
Move import of re and sys to the top with spaces.
There was a problem hiding this comment.
What do you mean with "with spaces"?
bruth
approved these changes
Jan 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solved this by removing if if dt.time() in the date_formats loop in the convert_datetime() method.