Properly convert dates with no timestamp to dates instead of datetimes #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the feedback @bruth I made the changes to make it a little more clean :) 👍 |
|
Great. Please squash the commits and add a good commit message and then I will merge. Thanks again. |
Check if the converted datetime object contains zero'd time If not pass onto the date_converter
|
There ya go! No problem, always glad to help a useful project! |
bruth
added a commit
that referenced
this pull request
Sep 18, 2015
Properly convert dates with no timestamp to dates instead of datetimes
|
Released 0.4.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the README it lists that the lib should convert to dates then datetimes (https://github.com/bruth/strconv#converters). I've found that it will convert a date string to a datetime object instead with all 0's for the time information. By checking if the time is zero'd out and passing if that's the case we can properly convert dates with no time information to actual date objects instead of datetimes.