Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Automatically account for holidays #54

Closed
ghost opened this issue Dec 21, 2019 · 6 comments
Closed

Feature Request: Automatically account for holidays #54

ghost opened this issue Dec 21, 2019 · 6 comments

Comments

@ghost
Copy link

ghost commented Dec 21, 2019

Please consider adding an automatic accounting for national holidays in the country of use.
For example, typically in the US, trash/recycling would be picked up one day later when a US holiday such as Christmas falls on a garbage collection day.

This is true in 2019, Christmas falls on Wednesday, so our local Garbage collection (normally Wednesday) will now happen on Thursday.

Adding a national holiday component based on country and a simple checkbox for the integration to observe holidays would be awesome. This avoid having to determine and add the holidays by individual date for an entire year, and also adding the dates to include, since the tool does not automatically account for it to happen one day later.

@bruxy70
Copy link
Owner

bruxy70 commented Dec 21, 2019

If it was the next day everywhere, that would be easy. I have looked into that some time ago. Turns out, there are so many different variants for when the next collection would happen. As well as not all holidays are automatically excluded, for example in my village - 25th will be a collection as normal, but 1/1 they will move it to Thursday. So after some thought, I went for a manual inclusion/exclusion.

@ghost
Copy link
Author

ghost commented Dec 21, 2019 via email

@bruxy70
Copy link
Owner

bruxy70 commented Dec 28, 2019

So, what I plan to do is, to use the holidays package. For the US, it renders the following list of US holidays for next year:

2020-01-01 New Year's Day
2020-01-20 Martin Luther King, Jr. Day
2020-02-17 Washington's Birthday
2020-05-25 Memorial Day
2020-07-04 Independence Day
2020-07-03 Independence Day (Observed)
2020-09-07 Labor Day
2020-10-12 Columbus Day
2020-11-11 Veterans Day
2020-11-26 Thanksgiving
2020-12-25 Christmas Day

The collections days would be a day later (regardless of if this comes on the weekend). But if this comes to another bank holiday it would be moved further to another day. Is that correct?

I am asking you to validate the logic before I do that, since I have no idea - they do not do that here. Suppose because they have different jobs scheduled for different days. So if they do the place I live on Wednesday, they do some other place (or different waste type) on Thursday. So if they did what they do in the US, they would have to make up for 2 and sometimes 3 days in 1 day. I wonder how they do that. Anyhow, let me know.

@ghost
Copy link
Author

ghost commented Dec 28, 2019 via email

bruxy70 pushed a commit that referenced this issue Dec 28, 2019
bruxy70 pushed a commit that referenced this issue Dec 29, 2019
@bruxy70
Copy link
Owner

bruxy70 commented Dec 29, 2019

Included in release 2.11. Check it out.

@ghost
Copy link
Author

ghost commented Dec 29, 2019 via email

@bruxy70 bruxy70 closed this as completed Dec 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant