Update to utilise skinshortcuts (0.5.3) for main menu, background, widgets #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Change skin shortcuts build lines to build mainmenu + submenu * Change main menu includes to use skinshortcuts main menu * Remove previous main menu includes * Remove submenu fallbacks * Change manage main menu button to activate skinshortcuts management dialog + add edit submenu item to management dialog
* Change management dialog from using GUI buttons 101/102/103/111 to 401 (generally considered a more user-friendly method and visually cleaner) * Change layout to match skinsettings * Remove background/widget/infoline buttons, to be re-implemented individually
|
Wow, thanks Bob, was not expecting this! I'm out of the country for the
|
* Define backgrounds in overrides.xml * For fanart, display dependant on whether the background property matches, with a fallback on using the background property directly to support single/multi-image * For live cases, display dependant on left substring matching, with the correct items loaded based on right substring matching
* Define those few widgets that aren’t automatically available in overrides.xml * Display weather widget dependant on widget=weather * Display other widgets based on !IsEmpty(widgetPath), and use widgetTarget + widgetPath to fill the list * Switch widget labels to vars * Ugly hack to hide widget background when widgets always visible + no widget selected
* Use button 404 to set InfoLine property based on properties defined in overrides * Update infoline variables to base on the new value of the InfoLine properties
braz96
pushed a commit
that referenced
this pull request
Sep 28, 2015
Update to utilise skinshortcuts (0.5.3) for main menu, background, widgets (Thanks Bob!)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I know you've moved on to Arctic, so if you're not interested in this that's no problem at all :)
I was curious just how difficult it would be to move Mimic to fully utilise Skin Shortcuts - as it is, a lot harder than I anticipated and I can understand exactly why you didn't do it! Still, I can never resist a challenge ;)
I've done it as multiple commits to try and make the changes easier to follow, but if you want to merge it (absolutely your choice, I won't be offended if you don't!) I'll happily squash the commits.
A couple of things to note about it:
I'm sure I had a second, but can't remember it nowremembered and fixed the second & updated PR) - the description text for the skinshortcuts management dialog is completely wrong :) (You'll see what I mean when you select certain options in the management dialog)Regards.