Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refine AoX calculation and include test attributes #301

Merged
merged 1 commit into from
May 25, 2024
Merged

Conversation

bryanlundberg
Copy link
Owner

@bryanlundberg bryanlundberg commented May 25, 2024

What does this PR do?

  • Fixes the calculation of the best AoX by adding logic to remove the best and worst times before calculating the average in the current interval.
  • Synchronize the statistics of the selected cube from all possible ways that offers a change cube option.
  • Synchronize the statistics after delete a cube session.
  • Adds some data-testid attributes as the purpose of this PR started to add more test. 🙄

By submitting this PR, I confirm that:

  • I have reviewed my code and believe it is ready for merging.
  • I understand that this PR may be subject to review and changes.
  • I agree to abide by the code of conduct and contributing guidelines of this project.

Copy link
Owner Author

@bryanlundberg bryanlundberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@bryanlundberg bryanlundberg merged commit 02dcf7e into main May 25, 2024
3 checks passed
@bryanlundberg bryanlundberg deleted the fix-metrics branch May 25, 2024 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant