Feat/custom context menu #316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryanlundberg
requested changes
Jun 21, 2024
There was a problem hiding this comment.
Hi @syrok94 I think you are taking a more complicated approach than necessary. Anyway, I found another issue.
- Menu lost position at scroll
-
Last solves imposible use menu
-
Its missing the 100% width
-
Font size, its too big
-
Black theme its not correct the text color
👋
|
Hi @bryanlundberg , will you please tell me the simplified way of doing this so that I can try it that way? |
|
Hey @syrok94 I carefully reviewed your implementation and it was fine. I helped you with some minor adjustments to the menu's positioning and styling, it was easier than explaining 😅 This feature looks ready to go, thanks for your work! |
|
Preview styled: Positioning / Colors / Size 82d82cd2283677a80d4c82274f763aa6.mp4 |
bryanlundberg
approved these changes
Jun 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
fix #270, add a context menu as well as fix its position
Related Issue(s)
none
Changes
Added a ContextMenu.tsx file which can be reused to add a context menu
Screenshots or GIFs (if applicable)
Additional Comments
none
By submitting this PR, I confirm that: