Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linux installer #3

Merged
merged 3 commits into from May 29, 2016
Merged

Linux installer #3

merged 3 commits into from May 29, 2016

Conversation

@artberri
Copy link
Contributor

@artberri artberri commented Mar 18, 2016

  • lib/installers/Linux.js added
  • README.md updated (change init.d with systemd)
  • Added bash header to svc to run properly on linux.
  • Fixes #2
@artberri artberri mentioned this pull request Mar 18, 2016
unit += '[Service]' + "\n";
unit += 'ExecStart=' + service.command + "\n";
unit += 'Restart=always' + "\n";
unit += 'StandardOutput=syslog' + "\n";

This comment has been minimized.

@bryanmacfarlane

bryanmacfarlane Mar 20, 2016
Owner

Is journald a better choice? I believe if not specified, then journald is chosen and that was created by the folks that created systemd. Is there a reason to go with syslog?

unit += "\n";
unit += '[Install]' + "\n";
unit += 'WantedBy=multi-user.target' + "\n";

This comment has been minimized.

@artberri
Copy link
Contributor Author

@artberri artberri commented Mar 21, 2016

  • I will use journal, you are right
  • I will double check about depending on network online

But I will also make some other changes, for example I will remove NODE_ENV=production, it causes node to not install devDependencies. It's a build server/agent, it is not production.

I'm checking it in a project that we are moving from Jenkins to VSO, once I have it working properly I'll came back with the fixes.

Thanks!

@artberri artberri changed the title Linux installer [WIP] Linux installer Mar 21, 2016
@artberri
Copy link
Contributor Author

@artberri artberri commented May 3, 2016

Hi again @bryanmacfarlane !

I think that now it's done. We have been running the vso-agent in Linux servers during a while (with systemd) successfuly, and we are now deploying to production with it also, (new VSTS Releases feature). Our migration from Jenkins was fine.

@artberri artberri changed the title [WIP] Linux installer Linux installer May 3, 2016
@bryanmacfarlane
Copy link
Owner

@bryanmacfarlane bryanmacfarlane commented May 28, 2016

Cool. I'll merge

Note that we have a new agent replacing the node.
https://github.com/microsoft/vsts-agent

@artberri
Copy link
Contributor Author

@artberri artberri commented May 29, 2016

Cool!

Yeah! I saw it the some days ago. We will wait until it gets out from beta to use it, anyway I'll start doing some tests.

It will replace the node.js one, but... Is it intended to replace also the Windows one?

@bryanmacfarlane
Copy link
Owner

@bryanmacfarlane bryanmacfarlane commented May 29, 2016

Yes. It will be the one agent.

@bryanmacfarlane bryanmacfarlane merged commit dd585e0 into bryanmacfarlane:master May 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants