Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support introspection of http major/minor version #2

Merged
merged 3 commits into from
Mar 3, 2021

Conversation

midnight-wonderer
Copy link
Contributor

Hi
This is the minimal patch to support http.rb.
Join the ongoing discussion here: httprb/http#639.

@bryanp
Copy link
Owner

bryanp commented Dec 30, 2020

Thanks! Can you add a test for each new method in spec/integration/parser/response_parsing/introspection_spec.rb? Here's an existing test for status_code: https://github.com/metabahn/llhttp/blob/248482d0ba3c3d09000e65b53357cbb4cd5215a2/spec/integration/parser/response_parsing/introspection_spec.rb#L54-L68

@bryanp bryanp added this to the v0.1.0 milestone Dec 30, 2020
@bryanp bryanp changed the title add http version fetching functionality Support introspection of http major/minor version Dec 30, 2020
@bryanp bryanp force-pushed the feature/http-version-fetching branch from bb20273 to 2327a6c Compare March 3, 2021 20:21
@bryanp bryanp merged commit 9523599 into bryanp:main Mar 3, 2021
@bryanp
Copy link
Owner

bryanp commented Mar 3, 2021

Thanks for the contribution!

@midnight-wonderer
Copy link
Contributor Author

Sorry for the lack of the following-up.
At the time, I heard that you planned for a big refactor (for ruby-ffi), so I originally intended to wait for some time.
Later I don't have spare time to look into it, so I leave it stale.

Thank you for the initiative for llhttp; Ruby needs more infra guys like you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants