Changes for Python 3.10 support #107
Conversation
Change http connection dependency Add httpx in requirements.txt Change api.py
|
@bryanyang0528 this one is critical for migration to Python 3.10. @dgkncelik @bryanyang0528 has been working to resolve CI pipeline issues and merging pull requests. can you fix the branch conflicts? I think once we have yours we can get a new release out! |
|
Sorry for the late response, let me correct it ASAP |
|
@KenCox94 I don't think I can migrate all CI processes to Gitlab Action in this days. So I add python3.10 on Travis CI temporary. |
| @@ -141,8 +138,8 @@ def _request2(self, endpoint, connection, body, method="POST", encoding="utf-8") | |||
| base64string = base64.b64encode(bytes("{}:{}".format(self.api_key, self.secret), "utf-8")).decode("utf-8") | |||
| headers["Authorization"] = "Basic %s" % base64string | |||
|
|
|||
| connection.request(method=method.upper(), url=url, headers=headers, body=data) | |||
| resp = connection.get_response() | |||
| resp = connection(method=method.upper(), url=url, headers=headers, body=data) | |||
There was a problem hiding this comment.
Sorry for my 5 cents, but I tried testing queries with HTTP/2 and found an issue which lead here. Connection (which is httpx.request object here) does not want body, but content argument instead. It looks like more refactoring is in order.
| print("Ending query because of time out! ({} seconds)".format(idle_timeout)) | ||
| return | ||
| else: | ||
| raise ValueError("Return code is {}.".format(streaming_response.status)) |
There was a problem hiding this comment.
Should be streaming_response.status_code?
|
@cordawyn thank you for bringing this up. |
|
@KenCox94 with all the changes I suggested above, I made it to the point where it tries to get the query response, I guess. Here's the error I get now: I remember I used to get this error when these env variables for Kafka were not set as suggested:
... but they are properly set now. Could be another reason I guess. The query itself is created in KSQL and I can "select" from it using ksql CLI. It worked fine in ksql-python with non-HTTP/2 querying though. |
|
OK, here is where I am at with this..........this API will NOT WORK w/ python >=3.10 if we don't implement some of these changes. So, @dgkncelik, If we don't hear anything back concerning the resolution of the branch conflicts within 48 hours I am going to close this pull request, make the changes you implemented, and open it as a new pull request. Please don't take this as me being terse but we have been sitting on this for a while now. The lapse isn't just on you; I understand that, but things have to get moving. @cordawyn @bryanyang0528 this pull request title is so encompassing that we really need to make this more of an epic. There isn't going to be a catch-all pull request to settle all problems with 3.10 as @cordawyn has demonstrated. @cordawyn could you take on what you have put forth? Just fix and submit a new pull request based on those. If not, could you submit these as issues so we remember these need addressed? I think it's important to get this request pushed through as it's such a simple fix but it will be renamed. Please let me know your thoughts on this and apologies for the sabbatical. I will be continuing some more aggressive work on this until the holidays here in the US. |
|
Closing will open a new pull request. |
Change http connection dependency
Add httpx in requirements.txt
Change api.py