Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed exception handling of ksql #81

Merged
merged 1 commit into from
Aug 25, 2020

Conversation

bbkchdhry
Copy link
Contributor

Hi team,

I am using ksql 0.10.1.1 version and it doesn't throw any error if I execute a wrong command.
But for the same code with previous ksql version 0.5.1.1 it shows the error.

My Code:
image

Error from ksql: 0.5.1.1
image

Result from ksql: 0.10.1.1
image

So, I have modified the code a little and now the exception handling is working fine.
image

@codecov
Copy link

codecov bot commented Aug 24, 2020

Codecov Report

Merging #81 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #81   +/-   ##
=======================================
  Coverage   74.65%   74.65%           
=======================================
  Files           7        7           
  Lines         363      363           
  Branches       48       48           
=======================================
  Hits          271      271           
  Misses         77       77           
  Partials       15       15           
Impacted Files Coverage Δ
ksql/api.py 70.54% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 81e0886...33c8be3. Read the comment docs.

@bryanyang0528
Copy link
Owner

@bbkchdhry Thanks. That's exactly what I would like to fix too.

@bryanyang0528 bryanyang0528 added this to the 0.10.2 milestone Aug 25, 2020
@bryanyang0528 bryanyang0528 merged commit 8a729c1 into bryanyang0528:master Aug 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants