Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant length check in secure_cmp #93

Merged
merged 1 commit into from
Sep 4, 2019
Merged

Remove redundant length check in secure_cmp #93

merged 1 commit into from
Sep 4, 2019

Conversation

jorickert
Copy link
Contributor

@jorickert jorickert commented Sep 4, 2019

See #92

@codecov
Copy link

codecov bot commented Sep 4, 2019

Codecov Report

Merging #93 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #93      +/-   ##
==========================================
+ Coverage    95.9%   95.92%   +0.01%     
==========================================
  Files          36       36              
  Lines        5596     5594       -2     
==========================================
- Hits         5367     5366       -1     
+ Misses        229      228       -1
Impacted Files Coverage Δ
src/util/mod.rs 100% <ø> (ø) ⬆️
src/hazardous/kdf/hkdf.rs 98.78% <0%> (-1.22%) ⬇️
src/hazardous/stream/xchacha20.rs 82.83% <0%> (-0.75%) ⬇️
src/hazardous/aead/chacha20poly1305.rs 88.72% <0%> (-0.6%) ⬇️
src/hazardous/aead/xchacha20poly1305.rs 84.86% <0%> (-0.46%) ⬇️
src/hazardous/stream/chacha20.rs 89.5% <0%> (+1.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6efb6f...8ffc22a. Read the comment docs.

Copy link
Member

@brycx brycx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @snsmac for your work on this, I really appreciate it.

@brycx brycx merged commit 5554a09 into orion-rs:master Sep 4, 2019
@jorickert jorickert deleted the redundant_lengt_check branch September 4, 2019 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants