Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable getrandom/js feature and test wasm32-unknown-unknown in CI #37

Merged
merged 2 commits into from
Nov 11, 2021

Conversation

brycx
Copy link
Owner

@brycx brycx commented Nov 10, 2021

fixes #36

@brycx
Copy link
Owner Author

brycx commented Nov 10, 2021

@achmadk You can try out this branch to see if it covers your use-case.

[dependencies.pasetors]
git = "https://github.com/brycx/pasetors"
branch = "wasm"

@achmadk
Copy link

achmadk commented Nov 10, 2021

Maybe you can implement those additional steps from this article

Maybe you can also publish generated files of wasm-pack build into npm registry. You can read article here.

@brycx
Copy link
Owner Author

brycx commented Nov 10, 2021

Maybe you can implement those additional steps from this article

All the steps of that article are covered, except for adding wasm-bindgen "and js-sys and web-sys if you need them". I don't know if the last two are needed in addition to wasm-bindgen, but is this the step you are referring to?

Maybe you can also publish generated files of wasm-pack build into npm registry. You can read article here.

This I won't do. I have never really worked with JS, nor used npm and I have no intentions of starting right now. I'll give it some more thought, perhaps I change my mind in the future. But for now, I don't want to maintain and update two different registries for this crate.

In extension to my lack of experience with JS, if you meant for me to use wasm-bindgen then I'd probably need some help with this due to my lack of knowledge there.

@achmadk
Copy link

achmadk commented Nov 10, 2021

All the steps of that article are covered, except for adding wasm-bindgen "and js-sys and web-sys if you need them". I don't know if the last two are needed in addition to wasm-bindgen, but is this the step you are referring to?

I think js-sys and web-sys not need to be added into Cargo.toml file.

In extension to my lack of experience with JS, if you meant for me to use wasm-bindgen then I'd probably need some help with this due to my lack of knowledge there.

Maybe I can help you although I still learning rust programming language for WASM.

@brycx
Copy link
Owner Author

brycx commented Nov 11, 2021

Thanks! If you end up working on it, feel free to ping me here or on email if you have any questions that I might be able to answer.

I'll merge this pull-request but keep the issue open.

@brycx brycx merged commit 1d810aa into master Nov 11, 2021
@brycx brycx deleted the wasm branch November 11, 2021 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add WASM/ WebAssembly support
2 participants